Fix scope validation on initiative's creation #8755
Merged
andreslucena merged 7 commits intodevelopfrom Feb 16, 2022
Merged
Conversation
Member
Author
|
I wanted to improve the current approach by doing the validation also in the model, but as far as I see this would involve changing the current data model with the Doing a I've also implemented some small cosmetic changes for a bit more consistency/cleanup of some things that were weird, like some styles in comments, spec's examples descriptions all in lowercase, removing unnecessary "required: true" attributes in forms, etc. |
entantoencuanto
added a commit
that referenced
this pull request
Feb 18, 2022
* develop: (134 commits) Remove Rectify::Presenter references (#8758) Clarify the locales on the list of admins (#8838) Fix activity cell disappearing author images (#8826) Fix notifications when there is a note proposal in other spaces than processes (#8822) Fix accountability text search (#8831) Fix displaying hidden meetings in show process page (#8823) Fix docs for install-decidim.sh permissions (#8839) Fix report moderation for all the spaces (#8813) Clarify the comment at the resource search class (#8829) Fix displaying hidden related resources (#8812) Replace Decidim mentions in UI with 'the platform' (#8827) Add natively a .keep file to empty directory to include on git committing (#8830) Fix scope validation on initiative's creation (#8755) Replace `searchlight` with `ransack` which is already a core dependency (#8748) Fix characters not encoded in highlighted participatory process group title (#8820) Test ensuring the moderated comments are not computed in stats (#8816) Update rails to 6.0.4.6 and puma to 5.6.2 (#8817) Fix displaying hidden meetings in processes group's "upcoming meetings" content block (#8818) Fix displaying hidden meetings in homepage's "upcoming meetings" content block (#8809) Improve "Release Candidates" release docs (#8804) ...
andreslucena
added a commit
that referenced
this pull request
Feb 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
As a participant, when I create a new initiative and I don't select any scope I get an error:
(There's a video below)
This PR fixes this client side. I think we can improve it, but it's at least a quick fix for this issue.
I don't know if this is compatible with the "Global scope"'s kind of settings that we have in the initiatives' admin settings.
Testing
📷 Screenshots
Before
initiative-type-bug.mp4
After