Skip to content

Test ensuring the moderated comments are not computed in stats#8816

Merged
andreslucena merged 1 commit intodecidim:developfrom
i-need-another-coffee:ale-enhance-stats-tests
Feb 15, 2022
Merged

Test ensuring the moderated comments are not computed in stats#8816
andreslucena merged 1 commit intodecidim:developfrom
i-need-another-coffee:ale-enhance-stats-tests

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

🎩 What? Why?

This PR adds 2 additional tests that would test the comments in meetings and proposals are not added to the stats count.

Testing

There is no decidim functionality added. Only several tests.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

@alecslupu alecslupu added module: meetings module: proposals type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Feb 15, 2022
@alecslupu alecslupu requested a review from roxanaopr February 15, 2022 07:52
@andreslucena andreslucena changed the title Ensure the moderated comments are not computed in stats Test ensuring the moderated comments are not computed in stats Feb 15, 2022
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 thanks!

@andreslucena andreslucena merged commit e63c8a8 into decidim:develop Feb 15, 2022
@alecslupu alecslupu deleted the ale-enhance-stats-tests branch February 15, 2022 11:34
entantoencuanto added a commit that referenced this pull request Feb 18, 2022
* develop: (134 commits)
  Remove Rectify::Presenter references (#8758)
  Clarify the locales on the list of admins (#8838)
  Fix activity cell disappearing author images (#8826)
  Fix notifications when there is a note proposal in other spaces than processes (#8822)
  Fix accountability text search (#8831)
  Fix displaying hidden meetings in show process page (#8823)
  Fix docs for install-decidim.sh permissions (#8839)
  Fix report moderation for all the spaces (#8813)
  Clarify the comment at the resource search class (#8829)
  Fix displaying hidden related resources (#8812)
  Replace Decidim mentions in UI with 'the platform' (#8827)
  Add natively a .keep file to empty directory to include on git committing (#8830)
  Fix scope validation on initiative's creation (#8755)
  Replace `searchlight` with `ransack` which is already a core dependency (#8748)
  Fix characters not encoded in highlighted participatory process group title (#8820)
  Test ensuring the moderated comments are not computed in stats (#8816)
  Update rails to 6.0.4.6 and puma to 5.6.2 (#8817)
  Fix displaying hidden meetings in processes group's "upcoming meetings" content block (#8818)
  Fix displaying hidden meetings in homepage's "upcoming meetings" content block (#8809)
  Improve "Release Candidates" release docs (#8804)
  ...
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: meetings module: proposals type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants