Fix notifications when there is a note proposal in other spaces than processes#8822
Merged
andreslucena merged 2 commits intodecidim:developfrom Feb 17, 2022
belighted:fix-proposal_note_created_event
Merged
Fix notifications when there is a note proposal in other spaces than processes#8822andreslucena merged 2 commits intodecidim:developfrom belighted:fix-proposal_note_created_event
andreslucena merged 2 commits intodecidim:developfrom
belighted:fix-proposal_note_created_event
Conversation
Member
|
Hi @sergei-krylov |
andreslucena
requested changes
Feb 16, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
Just a small change about traits
decidim-proposals/spec/events/decidim/proposals/admin/proposal_note_created_event_spec.rb
Outdated
Show resolved
Hide resolved
andreslucena
approved these changes
Feb 17, 2022
Member
|
Congrats for your first merged PR @sergei-krylov |
entantoencuanto
added a commit
that referenced
this pull request
Feb 18, 2022
* develop: (134 commits) Remove Rectify::Presenter references (#8758) Clarify the locales on the list of admins (#8838) Fix activity cell disappearing author images (#8826) Fix notifications when there is a note proposal in other spaces than processes (#8822) Fix accountability text search (#8831) Fix displaying hidden meetings in show process page (#8823) Fix docs for install-decidim.sh permissions (#8839) Fix report moderation for all the spaces (#8813) Clarify the comment at the resource search class (#8829) Fix displaying hidden related resources (#8812) Replace Decidim mentions in UI with 'the platform' (#8827) Add natively a .keep file to empty directory to include on git committing (#8830) Fix scope validation on initiative's creation (#8755) Replace `searchlight` with `ransack` which is already a core dependency (#8748) Fix characters not encoded in highlighted participatory process group title (#8820) Test ensuring the moderated comments are not computed in stats (#8816) Update rails to 6.0.4.6 and puma to 5.6.2 (#8817) Fix displaying hidden meetings in processes group's "upcoming meetings" content block (#8818) Fix displaying hidden meetings in homepage's "upcoming meetings" content block (#8809) Improve "Release Candidates" release docs (#8804) ...
andreslucena
pushed a commit
that referenced
this pull request
Feb 21, 2022
Member
This is not necessary anymore, I've already done that in #8865, as we want to make the v0.26.0 release ASAP, and as this is a fix it'll enter there. Thanks again for your PR @sergei-krylov |
Contributor
Author
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Fixes exception on user notifications page. the issue is on generating of proposal_url for a notification when proposal related to anything else except the participatory process.
🐞 The bug
The notification was introduced here and the related tests passes because in tests proposal is by default created for participatory_process.
So it works well with processes, and
decidim_admin_participatory_process_proposalsengine can properly generate the url for the proposal added to the participatory_process.The thing is that proposals can be added not only to the processes, but to a few other things, like assembly, initiative, consultation, etc:
https://github.com/decidim/decidim/search?q=%22include+Decidim%3A%3AParticipable%22
(check for
include Decidim::Participable)In those cases the engine would be a different one (accordingly to the component,
decidim_admin_assembly_proposalsfor assemblies, for example). This results to the error when rendering the ProposalNoteCreatedEvent notification:Participatory processes engine can't generate urls for the assemblies, and vise versa.
🔧 The fix
The fix is to use the mounted engine that is different depending on the proposal component, it picked from the
Participableconcern:decidim/decidim-core/lib/decidim/participable.rb
Lines 33 to 35 in 2540604
Testing