Skip to content

Fix activity cell disappearing author images#8826

Merged
andreslucena merged 2 commits intodecidim:developfrom
mainio:fix/activity-cell-disappearing-images
Feb 18, 2022
Merged

Fix activity cell disappearing author images#8826
andreslucena merged 2 commits intodecidim:developfrom
mainio:fix/activity-cell-disappearing-images

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

🎩 What? Why?

The activity cells do not consider if the author record has changed after the cell was cached.

For example, if the author changes their image, the images can suddenly disappear from the activity logs as shown in the attached screenshot (the user changed their avatar).

This also causes some other issues, such as the "Send private message" link linking to the sign in page even when the user is already signed in.

Testing

  • Enable caching for the system (default in production environments, e.g. MetaDecidim)
  • Sign in as a user
  • Add an avatar to the user
  • Create some activity that will appear in the activity listings (e.g. front page, user profile, etc.)
  • Take a look at the activity listing and see that the user avatar thumbnail is correctly displayed
  • Go to "My account" and change your avatar image
  • Take a look at the activity listing and see that the avatar disappeared because the cached image no longer exists

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Disappearing avatar images in the activity log:
Disappearing author avatars in activity logs

@ahukkanen ahukkanen added module: core type: fix PRs that implement a fix for a bug labels Feb 17, 2022
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!! 👍🏽

@andreslucena andreslucena merged commit 5188a0e into decidim:develop Feb 18, 2022
@ahukkanen ahukkanen deleted the fix/activity-cell-disappearing-images branch February 18, 2022 08:20
ahukkanen added a commit to mainio/decidim that referenced this pull request Feb 18, 2022
entantoencuanto added a commit that referenced this pull request Feb 18, 2022
* develop: (134 commits)
  Remove Rectify::Presenter references (#8758)
  Clarify the locales on the list of admins (#8838)
  Fix activity cell disappearing author images (#8826)
  Fix notifications when there is a note proposal in other spaces than processes (#8822)
  Fix accountability text search (#8831)
  Fix displaying hidden meetings in show process page (#8823)
  Fix docs for install-decidim.sh permissions (#8839)
  Fix report moderation for all the spaces (#8813)
  Clarify the comment at the resource search class (#8829)
  Fix displaying hidden related resources (#8812)
  Replace Decidim mentions in UI with 'the platform' (#8827)
  Add natively a .keep file to empty directory to include on git committing (#8830)
  Fix scope validation on initiative's creation (#8755)
  Replace `searchlight` with `ransack` which is already a core dependency (#8748)
  Fix characters not encoded in highlighted participatory process group title (#8820)
  Test ensuring the moderated comments are not computed in stats (#8816)
  Update rails to 6.0.4.6 and puma to 5.6.2 (#8817)
  Fix displaying hidden meetings in processes group's "upcoming meetings" content block (#8818)
  Fix displaying hidden meetings in homepage's "upcoming meetings" content block (#8809)
  Improve "Release Candidates" release docs (#8804)
  ...
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants