Replace searchlight with ransack which is already a core dependency#8748
Merged
andreslucena merged 113 commits intodecidim:developfrom Feb 16, 2022
Merged
Replace searchlight with ransack which is already a core dependency#8748andreslucena merged 113 commits intodecidim:developfrom
searchlight with ransack which is already a core dependency#8748andreslucena merged 113 commits intodecidim:developfrom
Conversation
Do not convert number 1 to `true` within the searches.
This base class is needed for searches that need context information such as the current user or current component.
This is in order to distinguish the ransackable_scopes between the admin users and the general users.
The filter class will not work for controllers/views which do not define a dedicated search_collection such as the global search page. For this reason, we revert back to the params based proxy class for building the forms. The `Ransack::Search` classes work just as well with the forms but they need to have a searchable collection behind them.
Contributor
Author
|
@andreslucena Thanks for the thorough testing! I found a few bugs in the accountability component through your issue report. These issues are now fixed. I also improved the E2E test suite for accountability to catch these issues in the testing pipeline and also to test the particular issue you reported about. |
andreslucena
approved these changes
Feb 16, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
As I said, I couldn't find any other bug, so I'm approving and merging it. The API seems clearer that the old one 😄
This was referenced Feb 16, 2022
entantoencuanto
added a commit
that referenced
this pull request
Feb 18, 2022
* develop: (134 commits) Remove Rectify::Presenter references (#8758) Clarify the locales on the list of admins (#8838) Fix activity cell disappearing author images (#8826) Fix notifications when there is a note proposal in other spaces than processes (#8822) Fix accountability text search (#8831) Fix displaying hidden meetings in show process page (#8823) Fix docs for install-decidim.sh permissions (#8839) Fix report moderation for all the spaces (#8813) Clarify the comment at the resource search class (#8829) Fix displaying hidden related resources (#8812) Replace Decidim mentions in UI with 'the platform' (#8827) Add natively a .keep file to empty directory to include on git committing (#8830) Fix scope validation on initiative's creation (#8755) Replace `searchlight` with `ransack` which is already a core dependency (#8748) Fix characters not encoded in highlighted participatory process group title (#8820) Test ensuring the moderated comments are not computed in stats (#8816) Update rails to 6.0.4.6 and puma to 5.6.2 (#8817) Fix displaying hidden meetings in processes group's "upcoming meetings" content block (#8818) Fix displaying hidden meetings in homepage's "upcoming meetings" content block (#8809) Improve "Release Candidates" release docs (#8804) ...
This was referenced Feb 21, 2022
12 tasks
This was referenced Aug 15, 2022
This was referenced Apr 20, 2023
This was referenced Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This migrates the participant view resource searching and filtering from the Searchlight implementation to Ransack because we don't need two separate ways of doing filtering within Decidim.
This is related to a larger Decidim refactoring effort of replacing gems with small communities with better maintained alternatives as well as removing unnecessary dependencies from Decidim that are essentially doing the same thing.
This is a breaking change and will require changes in 3rd party modules/applications that have:
📌 Related Issues
Testing
📋 Checklist
docs/.