Skip to content

Clarify the locales on the list of admins#8838

Merged
andreslucena merged 1 commit intodecidim:developfrom
PierreMesure:Clarify-the-list-of-administrators
Feb 18, 2022
Merged

Clarify the locales on the list of admins#8838
andreslucena merged 1 commit intodecidim:developfrom
PierreMesure:Clarify-the-list-of-administrators

Conversation

@PierreMesure
Copy link
Copy Markdown
Contributor

@PierreMesure PierreMesure commented Feb 17, 2022

🎩 What? Why?

This is a really small language fix for something that has been bugging several of our admins.

In the admin panel, the words used on the page with the list of admins is confusing.

Capture d’écran 2022-02-17 à 12 15 21

Capture d’écran 2022-02-17 à 12 15 35

This replaces Participants by Administrators in the title and New user by New admin in the button.
It also replaces Invite participant as administrator by Invite new administrator in the form to invite a new admin.

Capture d’écran 2022-02-17 à 12 13 51

Capture d’écran 2022-02-17 à 12 14 34

📌 Related Issues

  • I didn't create a point in MetaDecidim to keep it lightweight.
  • Note that the whole code for the admin index page is old and references to "users" everywhere. I haven't changed that as such a refactor should probably be decided by a member of the Product team. I just fixed the locales to avoid confusion for platform admins.

Testing

  • Just go to /admin/users

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

@andreslucena andreslucena added module: admin type: change PRs that implement a change for an existing feature labels Feb 18, 2022
@andreslucena andreslucena merged commit 424925e into decidim:develop Feb 18, 2022
@PierreMesure PierreMesure deleted the Clarify-the-list-of-administrators branch February 18, 2022 10:05
entantoencuanto added a commit that referenced this pull request Feb 18, 2022
* develop: (134 commits)
  Remove Rectify::Presenter references (#8758)
  Clarify the locales on the list of admins (#8838)
  Fix activity cell disappearing author images (#8826)
  Fix notifications when there is a note proposal in other spaces than processes (#8822)
  Fix accountability text search (#8831)
  Fix displaying hidden meetings in show process page (#8823)
  Fix docs for install-decidim.sh permissions (#8839)
  Fix report moderation for all the spaces (#8813)
  Clarify the comment at the resource search class (#8829)
  Fix displaying hidden related resources (#8812)
  Replace Decidim mentions in UI with 'the platform' (#8827)
  Add natively a .keep file to empty directory to include on git committing (#8830)
  Fix scope validation on initiative's creation (#8755)
  Replace `searchlight` with `ransack` which is already a core dependency (#8748)
  Fix characters not encoded in highlighted participatory process group title (#8820)
  Test ensuring the moderated comments are not computed in stats (#8816)
  Update rails to 6.0.4.6 and puma to 5.6.2 (#8817)
  Fix displaying hidden meetings in processes group's "upcoming meetings" content block (#8818)
  Fix displaying hidden meetings in homepage's "upcoming meetings" content block (#8809)
  Improve "Release Candidates" release docs (#8804)
  ...
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: admin type: change PRs that implement a change for an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants