Skip to content

Fix displaying hidden resources in global search#8811

Merged
andreslucena merged 7 commits intodecidim:developfrom
i-need-another-coffee:ale-exclude-search-hidden
Feb 18, 2022
Merged

Fix displaying hidden resources in global search#8811
andreslucena merged 7 commits intodecidim:developfrom
i-need-another-coffee:ale-exclude-search-hidden

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Feb 14, 2022

🎩 What? Why?

We are removing any search data from main index when the main resource is hidden by an administrator.

📌 Related Issues

Link your PR to an issue

Testing

  1. Go to Frontend interface and create a meeting
  2. Publish that particular meeting, then report it
  3. Verify the resource is being available in the search page
  4. Go to admin / Global moderations, choose hide meeting
  5. Go back to the search and repeat step 3 .
  6. The meeting SHOULD NOT be visible

♥️ Thank you!

@andreslucena andreslucena added module: meetings type: fix PRs that implement a fix for a bug labels Feb 14, 2022
@alecslupu alecslupu force-pushed the ale-exclude-search-hidden branch from ad1a418 to 33ccbbb Compare February 14, 2022 16:26
@andreslucena andreslucena changed the title Remove Hidden content from main search content Fix displaying hidden resources in global search Feb 15, 2022
@alecslupu alecslupu force-pushed the ale-exclude-search-hidden branch 2 times, most recently from a9d4d2d to 5e1d96c Compare February 16, 2022 14:53
@andreslucena
Copy link
Copy Markdown
Member

Just realized that we should also tackle the already existing moderated and hidden resources. If there's any manual action that implementers should do then we'd need to add it to the CHANGELOG

@alecslupu
Copy link
Copy Markdown
Contributor Author

Just realized that we should also tackle the already existing moderated and hidden resources. If there's any manual action that implementers should do then we'd need to add it to the CHANGELOG

@andreslucena , the commit 5672006 adds the Changelog and rake task.

@alecslupu
Copy link
Copy Markdown
Contributor Author

@andreslucena This can be merged.

@alecslupu alecslupu force-pushed the ale-exclude-search-hidden branch from 5672006 to b600381 Compare February 17, 2022 12:06
@alecslupu
Copy link
Copy Markdown
Contributor Author

@andreslucena last request has been fixed. this can be reviewed.

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@andreslucena andreslucena merged commit e9b4af0 into decidim:develop Feb 18, 2022
@andreslucena
Copy link
Copy Markdown
Member

Can you please backport to v0.26-stable 🙏🏽? Thanks

@alecslupu alecslupu deleted the ale-exclude-search-hidden branch February 18, 2022 10:14
alecslupu added a commit to i-need-another-coffee/decidim that referenced this pull request Feb 18, 2022
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@alecslupu
Copy link
Copy Markdown
Contributor Author

@andreslucena done in #8850

@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: meetings type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hidden (moderated) meetings are displayed in search

3 participants