Merged
Conversation
is to avoid using process.exitCode and instead use process.exit, but do so inside the callback for process.(stdout or stderr).write.
…tch impls. (#7343) * Added sentinel as URL parameter for Fast Fetch requests. * Removed test file. * Moved sentinel url param into impls; modified tests accordingly. * Removed unneeded code in test file.
* Kiosked ads * Indentation fix * lint error fix * lint error fix * lint error fix * ads.amp.html script fix * readme file change * implemented renderStart API for Kiosked plugin * indentation changes
* Add AdSpeed ad server to amp-ad * Change zid/oid to zone/client since oid is conflicting * Implemented renderStart() and noContentAvailable() API in AdSpeed backend. Tested both scenarios.
* Publish AMP cache modifications best practices
* Change the spec for `amp-audio[autoplay]` to correctly indicate that this is a boolean attribute, rather than the enum mentioned today. * Change amp-audio language to reference 'audio' rather than 'image'.
* add experiment flag * add cleanup issue * address comment * fix lint * nit
* `<meta http-equiv=>` tags must have `<head>` as ancestor. * Small javascript performance optimizations. * Remove the unused errors_seen flag. * Use requires/satisfies mechanism instead of also_requires_tag. * Refactoring: Make getAttrsFor simpler and less forgiving (spec now req. $GLOBAL_ATTRS / $AMP_LAYOUT_ATTRS) * Bugfix: Use hasOwnProperty to check whether the key is in the map. * No need to copy over TagSpec.requires. * Share empty arrays for the specification objects where possible. * Allow form elements outside of form tags. * Update amp-access-laterpay. * Add string intern table and use it for simple attrs. The ids for interned strings are negative integers, allowing us to effectively mix them in with ids for complex messages (AttrSpec in this case). * Validate that amp-install-serviceworker[data-iframe-src] is an https URL (if present). * Restrict AMP4ADS extensions. * Allow empty `src` attribute for `amp-pixel`. * Restrict AMP4ADS extensions (part two). * Rely on the global class attr (w/ blacklist) instead of a locally defined one. * html_format unnecessary for both AMP and AMP4ADS extensions. * Elminate SimpleParsedAttrSpec class and use attr ids directly for simple attrs. * Add additional SVG 2.0 elements. * Add SVG filters to AMP Validator rules. * revision bump for amp-call-tracking * Use indexOf instead of startsWith for old Node.js version compat. * Allow empty `config` attribute for `amp-analytics`. * Refactoring: Move the parseAttrsFor method into the constructor of ParsedTagSpec. * Remove `autoplay` attribute from `<amp-anim>` tag in validator. This attribute does nothing, and is not mentioned in the spec. * Change amp-audio[autoplay] from an enum to a boolean attribute. The spec indicates that it's an enum, but the code just passes this through to the audio tag it creates, which treats this as true/false * In generated JS, use ids to identify attr lists (instead of attr lists names). * Remove the tagSpecId field from the TagSpec class. * Replace requires and satisfied fields with interned strings. * Update amp-bind validation rules From PR 7127
* still need tests * need to fix test * fix lint * nit * add test coverage
…ecified node (#7439) * first pass at adding/removing subtrees * tests passing * Add ability to add and remove bindings in the subtree rooted at a specific node * lint fixes * merge conflict * ci issues * some cleanup * pr comments * pr comments, new method of removing bindings for node and its children * fix some lint warnings * test and lint fixes * update comments * pr comments * lint errors * pr comments * cleanup * lint errors * pr comments * pr comments and lint warnings * typo * more lint warnings * pr comment * pr comment
…#7580) * Refactor local proxy server code so it supports Viewer style URL: /v/ * address comment
* myWidget Ad extension * myWidget Ad extension - fix travis * myWidget Ad extension - fix travis * myWidget Ad extension - review fixes
* Additional required file was added * Asynchronous scripts loading
* Added amp-playbuzz item id support * Fixed amp-playbuzz preconnect * Added item-id to documentation * Added important remark to documentation * Refactored amp-playbuzz iframe src compose logic
…on) (#7466) * url + sourceUrl * rename * added test * remove only * fix * test fix * test
* initial commit to forbid exprs in obj keys * also support numbers and other primitives
* initial commit for worker blob * fix type error * malte's comments * fix unit tests
Missed copyright in original PR
* Replace CLICK_X and CLICK_Y in anchor href for amp-inabox. * Fix lint errors.
* Send expected errors to expected bucket * Increment errortracker version
* Updated CSS for amp-selector so the outline is less specific. (Issue #7534) * Added new line at end of file.
* first draft * added details inline; added quick start * added a preface for doc/test/etc. changes * minor fixes * responding to review comments; adding README
* initial changes * add test coverage * remove dependency on createIframePromise causing type check failure * build failures * build fix * fix test failure * change AV config from urls to url * PR review * Add scoped attribute to amp-analytics * fix lint error * fix lint error * fix presubmit error
* Pass nocurls as additional info to Viewer for latency tracking. * Add test. * use urls.cdn * Add comment. * ... * ... * rename experiment name * fix test
…xception (#7723) * Only use local storage if the API is declared and does not throw an exception (#6633) * Revert "Only use local storage if the API is declared and does not throw an exception (#6633)" This reverts commit fb0f11f. * Only use local storage if the API is declared and does not throw an exception (#6633) * Fix whitespace lint issue * Ensure that getItem is not called when attempting to load an item from local storage when local storage is not supported.
* Detect JS Engine when reporting errors This should save us some time trying to determine what the real browser is, not what the UserAgent is masquerading as. * Fix IE detection Also add comments * linting * JSDoc * Add error tests to integrations suite * Fix closure type check
* Add cache modifications of everything.amp.html
* first draft * more changes * more changes * more changes * more changes * providing more details for template sections * changing to milestone for Great First Issues
* Send GFP on 200th frame. * Fix lint * fix test * fix type checks
torch2424
pushed a commit
that referenced
this pull request
Mar 1, 2019
* creating new amp-smartlinks extension * BAM-2584 AMP-Smartlinks (#3) * adding example page and amp-smartlinks to bundles.config * creating amp-smartlinks scaffolding * BAM-2584 adding hardcoded POC implementation of amp-smartlinks * adding new constants file and linkmate file/class * adding linkmate call and association working with link-rewrite service * add amp config call and update workflow to use those values * setup initial amp-smartlinks and linkmate workflow * adding new config variables for link attribute and selector * add tests for amp-smartlinks * add test for linkmate.js * add more thorough anchorList check in runSmartlinks * adding code comments, new constants structure and better options validation * update amp-smartlinks to have helpful information * updating global vars and cleaning up main files * clean up tests and add more explicit type assertions * clean up jsdoc tags * BAM-2585 Whitelist import, fix type errors, and replace user.assert with userAssert (#4) * BAM-2585 whitelist navigation import and fix type errors * replace user.assert with userAssert * BAM-2585 fix validator and type check (#5) * more validator fixes (#6) * BAM-2585 Fix validator, copyright, and whitespace (#7) * alphabetize validator, fix whitespace, and add valid tag * update year in copyright statement * BAM-2585 move `link-rewriter` to import statements and updating types (#8) * BAM-2585 remove link-rewriter and switch to importing from skimlinks extension * clean up promise chain and more descriptive API comments * update xhr to pull from ampdoc.win and add types to constants.js * fix type in buildPageImpressionPayload_ * update validator with new empty value check (#9) * update validator for exclusive-links * switch page-impression API request to customEventReporter (ampproject#11) * BAM-2585 fix jsdoc in linkmate-options and unnecessary param in page_impression request (ampproject#12) * fix jsdoc for linkmate params and make runLinkmate more readable (ampproject#13) * add try/catch on amp_config fetch and updated constants.js * remove bad type in constants.js and add check for existing shop-links (ampproject#14) * add check for auction_id in mapLinks and add jsdoc for SMARTLINKS_REWRITER_ID * fix type notation in constants.js and linkmate-options.js * fix indentation in example file * add note to README describing link-rewriter priority queue behavior (ampproject#15) * add exception to compile.js for amp-skimlinks * update validator to use empty value as indicator linkmate param * fix validator and linkmate-options to use new config style (ampproject#16) * updating tests for linkmate-options.js * remove redundant userAssert in linkmate-options * update tests to reflect config changes * update tests to send accurate config params * update readme to refelct config changes and more accurate function names in linkmate-options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please pick a meaningful title for your pull request using sentence case.
Do not overuse punctuation in the title like
(chore):. If it is helpful feel free to start with a project name, though, likeProjectX: Implement some feature.Title instructions above.
Enter a succinct description of what is achieved by the PR. Ideally describe why the change is being made.
Bullet points like
really help with making this more readable.
Fixes/Implements/Related-to #1 (enter issue number, except in rare cases where none exists).