Allow allowpaymentrequest attribute on amp-iframe#7693
Merged
aghassemi merged 2 commits intoampproject:masterfrom Feb 21, 2017
Merged
Allow allowpaymentrequest attribute on amp-iframe#7693aghassemi merged 2 commits intoampproject:masterfrom
aghassemi merged 2 commits intoampproject:masterfrom
Conversation
aghassemi
reviewed
Feb 21, 2017
| const TAG_ = 'amp-iframe'; | ||
|
|
||
| /** @const {!Array<string>} */ | ||
| const PROPAGABLE_ATTRIBUTES_ = [ |
Contributor
There was a problem hiding this comment.
We have been using ATTRIBUTES_TO_PROPAGATE as the name in other places.
aghassemi
approved these changes
Feb 21, 2017
Contributor
aghassemi
left a comment
There was a problem hiding this comment.
Thanks! Just one nit request.
Member
Author
|
PTAL :) |
dc9bac0 to
8d41aa2
Compare
2 tasks
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue reference #7623