Syncing to latest Amp Master#3
Merged
torch2424 merged 152 commits intotorch2424:masterfrom Feb 14, 2017
Merged
Conversation
* Update docs for goToSlide * Update actions doc for goToSlide * Update carouse.md with type="slides" note * Update actions doc with type=slides
* Update csa.md Add note to indicate that only multiple-format AFSh ads are supported. * Update csa.md
* Squash chunk-scan commits * fix lint error * rename chunk to startupChunk, pass viewer from Chunks to StartupTask * fix lint and type errors * support timeRemaining in chunk tasks & misc clean up * justin's comments * dima's comments * malte's comments * style and lint fix * fix unit tests * missed a couple @Private declarations * fix scan iteration * remove for..of * more iteration on iteration * move element scan to helper method
* update bind docs * barb's comments
* add srcset support * fix types * rewrite urls for cache * ignore compiler warnings in third_party/caja * whitelist amp-bind to depend on sanitizer.js * ali's comments
* move bind examples to bind/ folder * add sandbox example * add ecommerce example * update titles * replace shirt images * move amp-state to <body> * move <amp-state> to bottom of body * fix amp-bind validator html and output
A single AMP page would already only connect to a given origin once ever 180 seconds. With this change the URL for doing this will not change within that time interval. That means that all AMP pages that run on computers with roughly correct clocks will request the same URL within a 180 seconds interval, which should make it easier for CDNs to respond efficiently.
* Add ads/relap Partial commit Update Relap * Fix to pass CI build * Add renderStart support * Change attributes order * Add double quotes around attribute values
* add advance bidder support for openx amp ad * update ads.extern.js for openx amp ad * add data.dfpSlot to ads.extern.js
* Ad type adverticum 3p script https/http support. * example change
…ts run on iOS 10 (#7171)
* Page-level visibility time for embed performance reporting * ping URL parameters and layout ping
* Move nonce test case to a more appropriate test file. * Remove no longer needed dispatch key generation from validator.js. * De-dupe all messages (subtrees of the rules object) and instantiate the parsed attr specs lazily. * Revision bump for validator-amp-analytics.protoascii * Update construction of blacklisted cdata regexp to no longer have a trailing `|` character. * Add a Closure define for disabling CSS parsing / validating.
* Restrict AMP4ADS extensions * update test
Fixes #6141 Allow for an additional domain (or list of domains) for which variable substitution is allowed in links.
Might fix #7476. Still investigating. Either way, this is a bug.
* add array polyfill, whitelist contains function * install the polyfill * debuggign test * typos * cleanup * cleanup * contains -> includes * more cleanup * forgot to update one contains to includes * whitelist * fix failing test * pr comments * added test * fixed slight issue with the polyfill * add test * typo * pr comments * cleanup * cleanup * pr comments * ci issues * more ci issues * even more ci issues * update whitelist * pr comments * remove ban on includes * pr comments
* html_format unnecessary for both AMP and AMP4ADS extensions * Update htmlformat test to test for amp4ads whitelist
* add support for Eulerian Analytics
* introduce Good Frame Probability * introduce Good Frame Probability
This makes them available to sub domains which is important for the foo.cdn.ampproject.org style domains.
* Content.ad: CDN domain processing * Changed let to const Converted let variable to const since it is never changed. * Updated to use parseUrl method
* add height/width 0 check to onLayoutMeasure * Re-execute check on later onLayoutMeasure calls * code cleanup * PR review * PR review
* Initial revision of Cxense Display amp-ad integration * Fixes based upon review-feedback * Fix of another alphabetic order mishap * Use validateData() for required ad-parameter + documentation-fixes
* Upgrade amp-ad support for Index Exchange * Upgrade amp-ad support for Index Exchange * Fix rendering bug * Upgrade amp-ad support for Index Exchange * Upgrade amp-ad support for Index Exchange
* initial commit for bind worker * move URL rewriting to bind service, add promise api * clean up, fix lint and type errors * install AmpWorker service * add web-worker experiment * add worker experiment fallback * type check web-worker.js * comments and tweaks * mark postMessage with OK * fix dep check and tests * add tests for amp-worker.js * malte's comments * move typedefs to separate file to avoid browserify from bundling polyfills into worker * fix test and type error * justin's comments * malte's comment * increment counter first * justin's comments * fix unit test * fix unit test in a different way
Most tests failed when executed together with other tests, because they relied on custom elements being installed in the main test window instead of a per test iframe. This was fixed by using `describes.realWin` instead of ad hoc code in tests. Made the `jsonEqual` chai method more robust by switching to a JSON stringify that is stable. Fixed one cause of side effects making the 3p-frame test flaky.
* Implement amp-call-tracking extension * Use isLayoutSizeDefined * Assert valid URL early * Remove unnecessary length check * Use firstElementChild to select anchor element * Cross-reference design doc and PR for amp-call-tracking element
This is a new extension, so we should make the script inclusion unique.
torch2424
pushed a commit
that referenced
this pull request
Sep 28, 2018
* fix AmpComponent format * lint * fix * add more * add /*review*/ for .innerHTML * comments * comments round 2 * comments round 3 * comments round 4 * revert one more * FIX TYPE
torch2424
pushed a commit
that referenced
this pull request
Oct 10, 2018
* fix AmpComponent format * lint * fix * add more * add /*review*/ for .innerHTML * comments * comments round 2 * comments round 3 * comments round 4 * revert one more * FIX TYPE
torch2424
pushed a commit
that referenced
this pull request
Mar 1, 2019
* creating new amp-smartlinks extension * BAM-2584 AMP-Smartlinks (#3) * adding example page and amp-smartlinks to bundles.config * creating amp-smartlinks scaffolding * BAM-2584 adding hardcoded POC implementation of amp-smartlinks * adding new constants file and linkmate file/class * adding linkmate call and association working with link-rewrite service * add amp config call and update workflow to use those values * setup initial amp-smartlinks and linkmate workflow * adding new config variables for link attribute and selector * add tests for amp-smartlinks * add test for linkmate.js * add more thorough anchorList check in runSmartlinks * adding code comments, new constants structure and better options validation * update amp-smartlinks to have helpful information * updating global vars and cleaning up main files * clean up tests and add more explicit type assertions * clean up jsdoc tags * BAM-2585 Whitelist import, fix type errors, and replace user.assert with userAssert (#4) * BAM-2585 whitelist navigation import and fix type errors * replace user.assert with userAssert * BAM-2585 fix validator and type check (#5) * more validator fixes (#6) * BAM-2585 Fix validator, copyright, and whitespace (#7) * alphabetize validator, fix whitespace, and add valid tag * update year in copyright statement * BAM-2585 move `link-rewriter` to import statements and updating types (#8) * BAM-2585 remove link-rewriter and switch to importing from skimlinks extension * clean up promise chain and more descriptive API comments * update xhr to pull from ampdoc.win and add types to constants.js * fix type in buildPageImpressionPayload_ * update validator with new empty value check (#9) * update validator for exclusive-links * switch page-impression API request to customEventReporter (ampproject#11) * BAM-2585 fix jsdoc in linkmate-options and unnecessary param in page_impression request (ampproject#12) * fix jsdoc for linkmate params and make runLinkmate more readable (ampproject#13) * add try/catch on amp_config fetch and updated constants.js * remove bad type in constants.js and add check for existing shop-links (ampproject#14) * add check for auction_id in mapLinks and add jsdoc for SMARTLINKS_REWRITER_ID * fix type notation in constants.js and linkmate-options.js * fix indentation in example file * add note to README describing link-rewriter priority queue behavior (ampproject#15) * add exception to compile.js for amp-skimlinks * update validator to use empty value as indicator linkmate param * fix validator and linkmate-options to use new config style (ampproject#16) * updating tests for linkmate-options.js * remove redundant userAssert in linkmate-options * update tests to reflect config changes * update tests to send accurate config params * update readme to refelct config changes and more accurate function names in linkmate-options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please pick a meaningful title for your pull request using sentence case.
Do not overuse punctuation in the title like
(chore):. If it is helpful feel free to start with a project name, though, likeProjectX: Implement some feature.Title instructions above.
Enter a succinct description of what is achieved by the PR. Ideally describe why the change is being made.
Bullet points like
really help with making this more readable.
Fixes/Implements/Related-to #1 (enter issue number, except in rare cases where none exists).