Add URL rewriting and srcset support to amp-bind#7206
Merged
dreamofabear merged 6 commits intoampproject:masterfrom Jan 27, 2017
Merged
Add URL rewriting and srcset support to amp-bind#7206dreamofabear merged 6 commits intoampproject:masterfrom
srcset support to amp-bind#7206dreamofabear merged 6 commits intoampproject:masterfrom
Conversation
Author
|
/to @aghassemi /cc @dvoytenko |
aghassemi
suggested changes
Jan 27, 2017
Contributor
aghassemi
left a comment
There was a problem hiding this comment.
Look good, just a small change request.
| blockedURLs: ['__amp_source_origin'], | ||
| }, | ||
| // TODO: Support `srcset`. | ||
| srcset: { |
Contributor
There was a problem hiding this comment.
there is no srcset on amp-video
| 'AMP-VIDEO', 'src', '__amp_source_origin')).to.be.false; | ||
|
|
||
| // srcset | ||
| expect(val.isResultValid( |
dreamofabear
commented
Jan 27, 2017
| blockedURLs: ['__amp_source_origin'], | ||
| }, | ||
| // TODO: Support `srcset`. | ||
| srcset: { |
| 'AMP-VIDEO', 'src', '__amp_source_origin')).to.be.false; | ||
|
|
||
| // srcset | ||
| expect(val.isResultValid( |
aghassemi
approved these changes
Jan 27, 2017
8837022 to
aaf60de
Compare
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Jan 31, 2017
* add srcset support * fix types * rewrite urls for cache * ignore compiler warnings in third_party/caja * whitelist amp-bind to depend on sanitizer.js * ali's comments
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Feb 14, 2017
* add srcset support * fix types * rewrite urls for cache * ignore compiler warnings in third_party/caja * whitelist amp-bind to depend on sanitizer.js * ali's comments
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
* add srcset support * fix types * rewrite urls for cache * ignore compiler warnings in third_party/caja * whitelist amp-bind to depend on sanitizer.js * ali's comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial for #6199.
srcsetattribute inBindValidator