Fix [slide] update to 0 bug#7229
Merged
dreamofabear merged 1 commit intoampproject:masterfrom Jan 27, 2017
Merged
Conversation
camelburrito
approved these changes
Jan 27, 2017
| mutatedAttributesCallback(mutations) { | ||
| const slide = mutations['slide']; | ||
| if (slide) { | ||
| if (slide !== undefined) { |
Contributor
There was a problem hiding this comment.
i guess you could also check if this is a number using our dev. util fn
Author
There was a problem hiding this comment.
We also want to support strings here so I think type#isFiniteNumber wouldn't suffice.
dreamofabear
commented
Jan 27, 2017
Author
dreamofabear
left a comment
There was a problem hiding this comment.
Thanks for the super quick review!
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Jan 31, 2017
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Feb 14, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7225.