Upgrade amp-ad support for Index Exchange#7074
Upgrade amp-ad support for Index Exchange#7074erwinmombay merged 7 commits intoampproject:masterfrom
Conversation
|
/to @lannka |
|
@lannka - can you give an ETA on when this will be reviewed? Thanks. |
ads/ix.js
Outdated
| callDoubleclick(global, data); | ||
| }, data.ixTimeout); | ||
|
|
||
| function callDoubleclick(global, data) { |
There was a problem hiding this comment.
can you make it a function variable? also, seems both params are not needed anymore
f41cc5a to
a463e42
Compare
|
@lannka - thanks for the feedback, we've made those changes. |
|
@lannka - Can we get an ETA on when this will be reviewed again? |
Fix rendering bug
|
There's a merge conflict that needs to be resolved before the next review. |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
I believe that cla/google warning is about me - yes I consent to my commits being contributed to this project. @lannka - can I get an ETA on this being reviewed? |
lannka
left a comment
There was a problem hiding this comment.
@erwinmombay could you help force merge the request?
|
|
||
| writeScript(global, 'https://js-sec.indexww.com/apl/apl6.js'); | ||
| loadScript(global, 'https://js-sec.indexww.com/apl/apl6.js', undefined, () => { | ||
| callDoubleclick(); |
There was a problem hiding this comment.
you can put callDoubleClick as the last param of loadScript
* Upgrade amp-ad support for Index Exchange * Upgrade amp-ad support for Index Exchange * Fix rendering bug * Upgrade amp-ad support for Index Exchange * Upgrade amp-ad support for Index Exchange
* Upgrade amp-ad support for Index Exchange * Upgrade amp-ad support for Index Exchange * Fix rendering bug * Upgrade amp-ad support for Index Exchange * Upgrade amp-ad support for Index Exchange
Updating amp-ad type "ix" to support timeout and handling network errors