Merged
Conversation
…e cached across pages (#6637) * Initial commit * Fix merge issues * PR responses * PR review * PR responses * PR responses
* Force-disable flag in experiments via cookies * minus prefix
* A4A Envelope for testing * wip * lints * docs
…cript's location (#6710)
… sidebar (#6706) * Support wider styling set for fixed layer. Re-enable forceTransfer on sidebar * Review changes and tests
…se() errors from being logged (#6680) * Eliminate useless The play() request was interrupted by a call to pause() errors from being logged * Eliminate useless The play() request was interrupted by a call to pause() errors from being logged
* add valid attribute entries for schema.org RDFa syntax * add tests for RDFa validation support * check that adding RDFa did not break meta@content * check that adding RDFa did not break meta@content * add a rule for RDFa link
* add expectedError method * add private helper method and tests * add private annotation * add createExpectedError method and fix xhr-impl
* Revision bump for `<amp-ooyala>` * Refactoring: Move the validation procedures out of ParsedAttrSpec. * Separate the validateUrlAndProtocol routine from ParsedUrlSpec. * Add uniqueness and matching tag checks to all extensions, with a few exceptions. * Separate the validation routine from ParsedUrlSpec. * Allow anchor hrefs to be empty strings. Easy part of the github issue. * Refactoring: Move validation routines out of ParsedTagSpec class * Refactoring. Move the cdata matcher out of the context object and into the tagstack object. * Move the Parsed* classes toward the top of the file. * Combine methods into computeCssParsingConfig. * Move `<amp-ooyala-player>` to correct path. * Disallowed id and name values. * Revision bump for RDF changes. * Small changes to amp-auto-ads and amp-bind rules.
* Use #cloneNode to clone FixedLayer body Re: #6706 (comment) Also removes a [temporary fix](#4097) that is [no longer necessary](#6033). * Fix test
* amp-list: customize array location in the response * lints * review fixes * lints
* FlyingCarpet: Ensure unbuilt elements eventually layout Fixes #6735. * Ensure only directly owned elements get layout * Linting
…Hopefully (#6743) * testing * delete * a * git mv * changes * more * a * size * integration test include script * track_tag.out * element stub unit test * out messages * test
* Restrict selection of srcset to the two closest values * review fixes * lints * removed width=undefined special case * review fixes
* Store either "someexp" or "-someexp" in cookie, never both. This is to fix the duplicated experiment entries in cookie. * Fixes a bug related to opt_transient . Adds a test for it. * Added one more test for transient. * Export a xforTesting function instead of the original function.
This fixes #6728. THe problem was that chunking can delay the handshake with the viewer for a very long time. During this time the viewer cannot tell the doc that it is now visible–and visibility triggers chunking to go into fast mode. With this change the aggressive chunking mode is only triggered when the doc has gotten into a state where it can communicate with the viewer; and the viewer communication code itself is never delayed in a chunk.
* amp-mustache script also_requires_tag_warning should be template * amp4ads testdata
Also makes console output friendlier for element related errors. Fixes #6776
…Custom Search Ads protocol) with AMP (#6518) * Initial commit for CSA AMP ad integration * update ads example * assign throwaway variable so compiler doesn't complain * fix lint errors * define _googCsa in backfill function * Add link to CSA docs in AdSense docs * fix test error * fix type error * feedback from jeff * update css example * create overflow on resize denied if it doesn't exist * fix from jeff's comments * initial stab at unit tests * first stab at unit tests * add test for backfill * lint issues * create helper functions and move to bottom * hongfei's feedback * use Object.assign and tryparsejson * update tests * code review changes change some variable names, mostly condense code * change global.innerHeight back to initial height global.innerHeight doesn't work because I need the height of the AMP container at the time of requesting the ads before the iframe is resized. Different browsers have different behaviors (some bust the iframe, some don't). Changing to global.innerHeight broke the overflow implementation on iOS. * force dom reflow after appending overflow iOS9 appears to have a race condition and sometimes shows the overflow on top of the ads, even though ALL containers and iframe appear to have the right height set . Adding this to see if it fixes the issue. This doesn’t appear to be a problem for iOS10 or Android. * Revert "force dom reflow after appending overflow" This reverts commit 2040f76. * hide overflow of CSA iframe I’m adding this because on ios9, the ad content is visible underneath the overflow element, even though the height of the container and iframe are being set correctly. * Set iframe width to 100% to prevent ios9 from breaking the overflow implementation * move code into functions * Move resize handlers to own functions, register in CSA function, not resizeIframe other minor refactoring as well * nitpicks * add forgotten breaks to switch statement * Create two callback functions, one for backfill and one without. * Merge remote-tracking branch 'ampproject/master' into csa-integration # Conflicts: # ads/google/csa.js * Inline backfill ads function * Merge with adsense.md accidentally replaced HC link * travis errors * more travis errors
* Update A4A spec to use a4a-v0.js * address comment
* TBD: proxying the form to call the prototype methods/properties * tests * FormProxy.prototype * docs * use Object.prototype.hasOwnProperty * fixes
#6787) * [amp-inabox] Only request position when visibility-v2 is disabled or native IntersectionObserver is not available. * Fix lint
* custom-element internal classes are switched to i-amphtml- form * fixes
* implement var dereferencing in action arg values * fix type error * add unit tests for applyActionInfoArgs() * fix lint error * PR comments * fix lint errors
* Refactor the computation of experiment config. * Removed cache for cookie toggles since it's only retrieved once. * Fix type checks * Fix tests * Remove unnecessary change of AMP_CONFIG for local testing. * Call resetExperimentToggleForTesting in _init_tests.js * Remove directly access to AMP_CONFIG for toggling experiments. * Add one more test case to make sure we have the right experiment status map. * Revert changes in test-traffic-experiments.js
…ed) (#6634) * Implement "hidden" trigger for VisibilityV2 (IntersectionObserver based visibility tracking). * Give test cases better names. * Address comments. * Address comment. * Fix tests.
* Add presubmit rule to disallow direct access to AMP_CONFIG. * Fix travis * Fix test
Migrated API to a more robust environment.
Merged
This was referenced May 31, 2017
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.