Added reference to common attributes + minor improvements (has dependency PR)#6772
Merged
1 commit merged intomasterfrom Dec 22, 2016
unknown repository
Merged
Added reference to common attributes + minor improvements (has dependency PR)#67721 commit merged intomasterfrom unknown repository
1 commit merged intomasterfrom
unknown repository
Conversation
Author
|
Barb will merge when other PR is in production |
Contributor
|
@bpaduch: Add a review "requesting changes". Then you'll have to approve before this is merged. |
Author
|
@jridgewell - How is that done if I'm the owner of the PR? |
Contributor
|
Go to "Files Changed" at the top, Click the "Review Changes" button, then select "Request changes" and submit. |
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Jan 3, 2017
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Jan 31, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to ampproject/amp.dev#276 - adding documentation for common attributes.
to: @pbakaus
cc: @cramforce
Note: Do not merge until ampproject/amp.dev#276 is in production.