Update A4A spec to use amp4ads-v0.js instead of v0.js#6152
Conversation
|
LGTM. @powdercloud , @Gregable FYI. |
extensions/amp-a4a/amp-a4a-format.md
Outdated
| 1. The creative must include `<script async src="https://cdn.ampproject.org/a4a-v0.js"></script>` | ||
| as the runtime script instead of `https://cdn.ampproject.org/v0.js`. | ||
|
|
||
| _Rationale_: Allows different runtime behaviors taylored to A4A. |
There was a problem hiding this comment.
A4A is such an overloaded term... here you mean it as essentially the amp-inabox case. Perhaps be more explicit?
There was a problem hiding this comment.
yep. but in this context I think there's no need to mention amp-inabox. A4A creative builder just need to remember to include a4a-v0.js, which is slightly different than v0.js (to support amp-inabox).
There was a problem hiding this comment.
Have you considered calling it amp4ads instead of a4a? This would be consistent with the <html amp4ads> opening of the document.
There was a problem hiding this comment.
@powdercloud @jasti so we're talking about renaming a4a-v0.js to amp4ads-v0.js?
Discussed in other thread, renaming the script file makes sense to me. Just FYI, there's other script currently named a4a-host-v0.js should be renamed to amp4ads-host-v0.js.
* Update A4A spec to use a4a-v0.js * address comment
* Update A4A spec to use a4a-v0.js * address comment
will wait till
amp4ads-v0.jsis released to productionFor #5700