Skip to content

Making amp-video an extension + backwards compatibility #TheLastOne #Hopefully#6743

Merged
chenshay merged 13 commits intoampproject:masterfrom
chenshay:test
Dec 20, 2016
Merged

Making amp-video an extension + backwards compatibility #TheLastOne #Hopefully#6743
chenshay merged 13 commits intoampproject:masterfrom
chenshay:test

Conversation

@chenshay
Copy link
Copy Markdown
Contributor

@chenshay chenshay commented Dec 19, 2016

  1. Moving all functionality to amp-video extension
  2. Backwards compatibility
  3. Create Video Manager only when you need it and only once

close #5306

@cramforce
Copy link
Copy Markdown
Member

Just wanted to get some context: Did you create a new pull request?

@chenshay
Copy link
Copy Markdown
Contributor Author

@cramforce yes + closed the other one

@chenshay chenshay merged commit edaada4 into ampproject:master Dec 20, 2016
@chenshay chenshay deleted the test branch December 20, 2016 21:25
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
…Hopefully (ampproject#6743)

* testing

* delete

* a

* git mv

* changes

* more

* a

* size

* integration test include script

* track_tag.out

* element stub unit test

* out messages

* test
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
…Hopefully (ampproject#6743)

* testing

* delete

* a

* git mv

* changes

* more

* a

* size

* integration test include script

* track_tag.out

* element stub unit test

* out messages

* test
torch2424 pushed a commit to torch2424/amphtml that referenced this pull request Jan 3, 2017
…Hopefully (ampproject#6743)

* testing

* delete

* a

* git mv

* changes

* more

* a

* size

* integration test include script

* track_tag.out

* element stub unit test

* out messages

* test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move <amp-video> and video-manager out of core (but stay backward compatible)

2 participants