amp-list: customize array location in the response#6745
amp-list: customize array location in the response#6745dvoytenko merged 4 commits intoampproject:masterfrom
Conversation
|
looks good for validator changes. ping me when you've submitted it. |
| if (expr == '.') { | ||
| return obj; | ||
| } | ||
| // Otherwise, navigate via properties. |
There was a problem hiding this comment.
Switch hasOwnProperty to Object.prototype.hasOwnProperty.call
|
Nice—excited to get this enhancement out! |
|
Thanks! When should we see this in production? |
* amp-list: customize array location in the response * lints * review fixes * lints
* amp-list: customize array location in the response * lints * review fixes * lints
|
After Jan 5th. Please see https://github.com/ampproject/amphtml/releases |
* amp-list: customize array location in the response * lints * review fixes * lints
|
Oh, so still slated for release... (feature request is somewhat referenced here too: #3554 ) |
|
@dvoytenko, Yups it was in prod the next day I wrote here. Nested list is perfect now. I didn't update here as I was facing some issue with cliping of content (in terms of visibility on ui) which was not happening earlier and I was trying to figure out if my config/html layout is faulty. |
|
One thing I notice is for nested list item, you still have to specify the src mandatorily and even src url is same that url endpoint is called as many times as you specify it. To elaborate consider the following snippet for which mustache template is already defined as Notice that
Now whats happening is Can some configuration be done to avoid unnecessary repeated call to CORS end point. (Its like I am billed 3x for api that actually owe 1x 😃, plus more processing and latency ) |
|
@cramforce Would this be solved by the |
|
This will be handled by #7562. |
|
Yes #7562 will do this. |
Fixes #6507.
/cc @dandv, @ericlindley-g for the feature
/cc @Gregable @honeybadgerdontcare @powdercloud for validator changes
/cc @bpaduch for spec/docs changes