Skip to content

A4A Envelope for testing#6698

Merged
dvoytenko merged 4 commits intoampproject:masterfrom
dvoytenko:fie10
Dec 15, 2016
Merged

A4A Envelope for testing#6698
dvoytenko merged 4 commits intoampproject:masterfrom
dvoytenko:fie10

Conversation

@dvoytenko
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Member

@cramforce cramforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very, very nice. One comment

}

/**
* @param {string} source
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document this and make clear in the name that it is for local dev only.

Missing @return

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dvoytenko dvoytenko merged commit d6ebc53 into ampproject:master Dec 15, 2016
@dvoytenko dvoytenko deleted the fie10 branch December 15, 2016 23:39
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
* A4A Envelope for testing

* wip

* lints

* docs
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
* A4A Envelope for testing

* wip

* lints

* docs
torch2424 pushed a commit to torch2424/amphtml that referenced this pull request Jan 3, 2017
* A4A Envelope for testing

* wip

* lints

* docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants