Merged
Conversation
erwinmombay
approved these changes
Nov 4, 2016
Member
|
restarting build. it died for some reason |
jridgewell
added a commit
to jridgewell/amphtml
that referenced
this pull request
Dec 16, 2016
Re: ampproject#6706 (comment) Also removes a [temporary fix](ampproject#4097) that is [no longer necessary](ampproject#6033).
jridgewell
added a commit
to jridgewell/amphtml
that referenced
this pull request
Dec 16, 2016
Re: ampproject#6706 (comment) Also removes a [temporary fix](ampproject#4097) that is [no longer necessary](ampproject#6033).
jridgewell
added a commit
to jridgewell/amphtml
that referenced
this pull request
Dec 16, 2016
Re: ampproject#6706 (comment) Also removes a [temporary fix](ampproject#4097) that is [no longer necessary](ampproject#6033).
jridgewell
added a commit
to jridgewell/amphtml
that referenced
this pull request
Dec 16, 2016
Re: ampproject#6706 (comment) Also removes a [temporary fix](ampproject#4097) that is [no longer necessary](ampproject#6033).
jridgewell
added a commit
to jridgewell/amphtml
that referenced
this pull request
Dec 16, 2016
Re: ampproject#6706 (comment) Also removes a [temporary fix](ampproject#4097) that is [no longer necessary](ampproject#6033).
jridgewell
added a commit
that referenced
this pull request
Dec 20, 2016
* Use #cloneNode to clone FixedLayer body Re: #6706 (comment) Also removes a [temporary fix](#4097) that is [no longer necessary](#6033). * Fix test
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Use #cloneNode to clone FixedLayer body Re: ampproject#6706 (comment) Also removes a [temporary fix](ampproject#4097) that is [no longer necessary](ampproject#6033). * Fix test
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Use #cloneNode to clone FixedLayer body Re: ampproject#6706 (comment) Also removes a [temporary fix](ampproject#4097) that is [no longer necessary](ampproject#6033). * Fix test
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Jan 3, 2017
* Use #cloneNode to clone FixedLayer body Re: ampproject#6706 (comment) Also removes a [temporary fix](ampproject#4097) that is [no longer necessary](ampproject#6033). * Fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revert https://github.com/ampproject/amphtml/pull/4089/files
close #4097