Add presubmit rule to disallow direct access to AMP_CONFIG.#6800
Merged
lannka merged 3 commits intoampproject:masterfrom Dec 29, 2016
Merged
Add presubmit rule to disallow direct access to AMP_CONFIG.#6800lannka merged 3 commits intoampproject:masterfrom
lannka merged 3 commits intoampproject:masterfrom
Conversation
| expect(postMessageStub).to.be.calledWith( | ||
| serializeMessage('request-type', 'sentinel-123')); | ||
| expect(postMessageStub).to.be.calledWith(serializeMessage( | ||
| 'request-type', 'sentinel-123', {}, '$internalRuntimeVersion$')); |
There was a problem hiding this comment.
Are the changes in this file related to the PR?
Contributor
Author
There was a problem hiding this comment.
yes. the change in 3p/iframe-messaging-client.js broke this test.
There was a problem hiding this comment.
Ah I see -- mode#getRtvVersion returns a different value in local dev.
dreamofabear
approved these changes
Dec 29, 2016
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Jan 3, 2017
…ct#6800) * Add presubmit rule to disallow direct access to AMP_CONFIG. * Fix travis * Fix test
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Jan 31, 2017
…ct#6800) * Add presubmit rule to disallow direct access to AMP_CONFIG. * Fix travis * Fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.