Refactor postDocumentLoaded in viewer and refine viewer tests#6638
Merged
muxin merged 2 commits intoampproject:masterfrom Dec 15, 2016
Merged
Refactor postDocumentLoaded in viewer and refine viewer tests#6638muxin merged 2 commits intoampproject:masterfrom
muxin merged 2 commits intoampproject:masterfrom
Conversation
3729355 to
4de5dff
Compare
lannka
approved these changes
Dec 15, 2016
src/service/resources-impl.js
Outdated
| * Inform the viewer with documentLoaded message | ||
| * @private | ||
| */ | ||
| postDocumentLoaded_() { |
Contributor
There was a problem hiding this comment.
the method name is a bit ambiguous. maybe we can just inline this whole method.
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Jan 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #6159