custom-element internal classes are switched to i-amphtml- form#6796
Merged
dvoytenko merged 2 commits intoampproject:masterfrom Dec 22, 2016
Merged
custom-element internal classes are switched to i-amphtml- form#6796dvoytenko merged 2 commits intoampproject:masterfrom
dvoytenko merged 2 commits intoampproject:masterfrom
Conversation
jridgewell
approved these changes
Dec 22, 2016
Contributor
jridgewell
left a comment
There was a problem hiding this comment.
Why do we need to add all the TODOs?
css/amp.css
Outdated
| /* TODO(dvoytenko, #6794): Remove old `-amp-replaced-content` form after the new | ||
| form is in PROD for 1-2 weeks. */ | ||
| .-amp-replaced-content, | ||
| i-amphtml-replaced-content { |
Contributor
There was a problem hiding this comment.
missing . as in .i-amphtml-replaced-content
Contributor
Author
There was a problem hiding this comment.
Fixed. Thanks! Very good catch!
css/amp.css
Outdated
| /* TODO(dvoytenko, #6794): Remove old `-amp-fill-content` form after the new | ||
| form is in PROD for 1-2 weeks. */ | ||
| .-amp-fill-content, | ||
| i-amphtml-fill-content { |
Contributor
There was a problem hiding this comment.
missing . as in .i-amphtml-fill-content
Contributor
Author
There was a problem hiding this comment.
Fixed. Thanks! Very good catch!
Contributor
Author
|
@honeybadgerdontcare PTAL @jridgewell There will be a major cleanup phase once the changes make to PROD. |
honeybadgerdontcare
approved these changes
Dec 22, 2016
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Jan 3, 2017
…roject#6796) * custom-element internal classes are switched to i-amphtml- form * fixes
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Jan 31, 2017
…roject#6796) * custom-element internal classes are switched to i-amphtml- form * fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial for #6463.
/cc @honeybadgerdontcare