Skip to content

Fix json-ld mainEntityOfPage example#6691

Merged
jridgewell merged 1 commit intoampproject:masterfrom
sisidovski:fix-json-ld-example
Dec 20, 2016
Merged

Fix json-ld mainEntityOfPage example#6691
jridgewell merged 1 commit intoampproject:masterfrom
sisidovski:fix-json-ld-example

Conversation

@sisidovski
Copy link
Copy Markdown
Contributor

@sisidovski sisidovski commented Dec 15, 2016

Some json-ld examples are inconsistent with their comments.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@sisidovski
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@jridgewell
Copy link
Copy Markdown
Contributor

/to @bpaduch

@jridgewell
Copy link
Copy Markdown
Contributor

@sisidovski: Can you say "I signed it!" again? Sometimes the bot doesn't work. 😞

@sisidovski
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@jridgewell jridgewell merged commit 6d446ca into ampproject:master Dec 20, 2016
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
torch2424 pushed a commit to torch2424/amphtml that referenced this pull request Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants