Content.ad: Improved reliability and security#6805
Merged
zhouyx merged 1 commit intoampproject:masterfrom Dec 29, 2016
Merged
Conversation
Migrated API to a more robust environment.
Contributor
|
/to @zhouyx |
Contributor
|
@jlucero-contentad The code looks good. However with your new change in, I am not able to see your ad example in our test page. I get |
Contributor
Author
|
@zhouyx I'm not able to reproduce that error on my local. Did you get the error for all of the Content.ad ads or just the first one? As mentioned in this merge request, we migrated our API to new servers; so it could be an intermittent error. |
Contributor
|
@jlucero-contentad it was with all content.ad ads. You're right, able to see them today. LGTM |
zhouyx
approved these changes
Dec 29, 2016
lannka
approved these changes
Dec 29, 2016
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Jan 3, 2017
Migrated API to a more robust environment.
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Jan 31, 2017
Migrated API to a more robust environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated API to a more robust environment.