Skip to content

adds support for Eulerian Analytics#7053

Merged
avimehta merged 9 commits intoampproject:masterfrom
guillaumef:master
Feb 11, 2017
Merged

adds support for Eulerian Analytics#7053
avimehta merged 9 commits intoampproject:masterfrom
guillaumef:master

Conversation

@guillaumef
Copy link
Copy Markdown
Contributor

No description provided.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@guillaumef
Copy link
Copy Markdown
Contributor Author

guillaumef commented Jan 17, 2017

I signed it!
Eulerian Technologies

@jridgewell
Copy link
Copy Markdown
Contributor

/to @avimehta

@guillaumef
Copy link
Copy Markdown
Contributor Author

Should I do something else here? quite disturbed by the "To be deprecated - 3P"
Thanks

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

Copy link
Copy Markdown
Contributor

@avimehta avimehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @dvoytenko fyi

@avimehta avimehta merged commit 00e53e2 into ampproject:master Feb 11, 2017
@avimehta
Copy link
Copy Markdown
Contributor

@guillaumef This should go out in next or the the release after that.

"To be deprecated - 3P" is actually indicating that the "3P" label is getting deprecated. Nothing to do with your PR.

torch2424 pushed a commit to torch2424/amphtml that referenced this pull request Feb 14, 2017
* add support for Eulerian Analytics
mrjoro pushed a commit to mrjoro/amphtml that referenced this pull request Apr 28, 2017
* add support for Eulerian Analytics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants