Fix locally failing tests.#7535
Merged
cramforce merged 5 commits intoampproject:masterfrom Feb 14, 2017
Merged
Conversation
Most tests failed when executed together with other tests, because they relied on custom elements being installed in the main test window instead of a per test iframe. This was fixed by using `describes.realWin` instead of ad hoc code in tests. Made the `jsonEqual` chai method more robust by switching to a JSON stringify that is stable. Fixed one cause of side effects making the 3p-frame test flaky.
erwinmombay
reviewed
Feb 14, 2017
package.json
Outdated
| "gzip-size": "3.0.0", | ||
| "jison": "0.4.15", | ||
| "jsdom": "9.2.1", | ||
| "json-stable-stringify": "^1.0.1", |
erwinmombay
approved these changes
Feb 14, 2017
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Feb 14, 2017
Most tests failed when executed together with other tests, because they relied on custom elements being installed in the main test window instead of a per test iframe. This was fixed by using `describes.realWin` instead of ad hoc code in tests. Made the `jsonEqual` chai method more robust by switching to a JSON stringify that is stable. Fixed one cause of side effects making the 3p-frame test flaky.
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
Most tests failed when executed together with other tests, because they relied on custom elements being installed in the main test window instead of a per test iframe. This was fixed by using `describes.realWin` instead of ad hoc code in tests. Made the `jsonEqual` chai method more robust by switching to a JSON stringify that is stable. Fixed one cause of side effects making the 3p-frame test flaky.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most tests failed when executed together with other tests, because they relied on custom elements being installed in the main test window instead of a per test iframe. This was fixed by using
describes.realWininstead of ad hoc code in tests.Made the
jsonEqualchai method more robust by switching to a JSON stringify that is stable. Fixed one cause of side effects making the 3p-frame test flaky.