Merged
Conversation
camelburrito
approved these changes
Jan 27, 2017
| <tr> | ||
| <td width="30%">amp-carousel</td> | ||
| <td>goToSlide</td> | ||
| <td>Advances the carousel to a specified slide index</td> |
| </amp-carousel> | ||
| ``` | ||
|
|
||
| ### Advancing the carousel to a specific slide |
Contributor
There was a problem hiding this comment.
you will need to specify this works for type="slides" only
Contributor
Author
There was a problem hiding this comment.
Updated — thanks!
Contributor
|
LG other than 2 comments |
ghost
approved these changes
Jan 27, 2017
Contributor
Author
|
@camelburrito Made the changes (good eye :) and ready to merge. Thanks! |
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Jan 31, 2017
* Update docs for goToSlide * Update actions doc for goToSlide * Update carouse.md with type="slides" note * Update actions doc with type=slides
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Feb 14, 2017
* Update docs for goToSlide * Update actions doc for goToSlide * Update carouse.md with type="slides" note * Update actions doc with type=slides
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
* Update docs for goToSlide * Update actions doc for goToSlide * Update carouse.md with type="slides" note * Update actions doc with type=slides
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if you've already put some of this together, @camelburrito , but I made some quick documentation for the goToSlide method.
/to @camelburrito & @bpaduch for review