Initial revision of Cxense Display amp-ad integration#7333
Initial revision of Cxense Display amp-ad integration#7333jridgewell merged 4 commits intoampproject:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
|I signed it!|
…On 02/03/2017 03:23 PM, googlebot wrote:
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at
your pull request, you'll need to sign a Contributor License Agreement
(CLA).
📝 *Please visit https://cla.developers.google.com/ to sign.*
Once you've signed, please reply here (e.g. |I signed it!|) and we'll
verify. Thanks.
------------------------------------------------------------------------
* If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check
your existing CLA data <https://cla.developers.google.com/clas>
and verify that your email is set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
* If you signed the CLA as a corporation, please let us know the
company's name.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7333 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AYWO0kjgHB4tFsnA0whDwIvOrK0iz_qlks5rYzhjgaJpZM4L2YU6>.
|
|
CLAs look good, thanks! |
|
/to @lannka |
| import {dotandads} from '../ads/dotandads'; | ||
| import {doubleclick} from '../ads/google/doubleclick'; | ||
| import {eplanning} from '../ads/eplanning'; | ||
| import {eas} from '../ads/eas'; |
| register('dotandads', dotandads); | ||
| register('doubleclick', doubleclick); | ||
| register('eplanning', eplanning); | ||
| register('eas', eas); |
ads/_config.js.orig
Outdated
| @@ -0,0 +1,592 @@ | |||
| /** | |||
| # Cxense Display ad server (formerly Emediate Ad) | ||
|
|
||
| ## Supported parameters in the amp-ad tag | ||
|
|
There was a problem hiding this comment.
please correct the format here
There was a problem hiding this comment.
Ok, changed title to just "CxenseDisplay" instead, I hope that was what you where referring to (otherwise let me know what's wrong)
There was a problem hiding this comment.
Didn't mean the title.
I understand that you want to put a table of supported parameters here, but if you take a look of the file you will find that the format is messed up.
The easiest way is to get rid of the table. One example for you reference.
https://github.com/ampproject/amphtml/blob/master/ads/google/adsense.md
There was a problem hiding this comment.
Ok, finally got the point.. table is removed
extensions/amp-ad/amp-ad.md
Outdated
| - [Dot and Media](../../ads/dotandads.md) | ||
| - [Doubleclick](../../ads/google/doubleclick.md) | ||
| - [E-Planning](../../ads/eplanning.md) | ||
| - [CxenseDisplay](../../ads/eas.md) |
ads/eas.md
Outdated
|
|
||
| ## Configuration | ||
|
|
||
| For `data-eas-domain=`<YourAdServerDomain>`, use your ad-server domain (e. g. eas3.emediate.se); If you're using a custom domain-name (like eas.somesite.com) you should NOT use that one unless you already have an SSL-certificate installed on our ad servers. |
|
Sorry for that mistakes, now it should hopefully look better! |
| * @param {!Object} data | ||
| */ | ||
| export function eas(global, data) { | ||
| global.easAmpParams = data; |
There was a problem hiding this comment.
Since data-eas-domain is required, I would suggest adding validateData(data, ['eas-domain']) here.
There was a problem hiding this comment.
Implemented using 'easDomain' because of the name-conversion
ads/eas.md
Outdated
| data-eas-cu="12345" | ||
| data-eas-EASTsomename="somevalue" | ||
| data-eas-kw1="somekeyword" | ||
| > |
There was a problem hiding this comment.
nit: move to the previous line
|
Ok, here's next attempt, validateData() is used and the documentation should have the right format. |
|
LGTM ping @lannka |
|
Merging since both of you LGTM'd. |
* Initial revision of Cxense Display amp-ad integration * Fixes based upon review-feedback * Fix of another alphabetic order mishap * Use validateData() for required ad-parameter + documentation-fixes
* Initial revision of Cxense Display amp-ad integration * Fixes based upon review-feedback * Fix of another alphabetic order mishap * Use validateData() for required ad-parameter + documentation-fixes
This is an integration for the Cxense Display (formerly Emediate Ad) ad server.
Details
This is a minimal implementation that uses writeScript() to fetch the "real" integration script, for more flexibility:
https://amp.emediate.eu/amp.v0.js
The reason the name "eas" is used for type, etc, is because that abbreviation is used in all of our APIs, etc, due to historical reasons.