Updating fork with latest master#5
Merged
torch2424 merged 912 commits intotorch2424:masterfrom May 31, 2017
Merged
Conversation
* Really run Saucelabs on latest browser versions. * Skip a test failure on FF53 * unskip test
* Force layout of elements used in animations * cleanup * fixed tests * check measure/display after build * deflake tests
Remove placeholder and fallback #8176 (comment) Add required param description #8176 (comment) Use encodeURIComponent #8176 (comment) #8176 (comment) indent
* Add info on overflow element for ad resizing * Added subheading per feedback
…les are in the same PR (#9166)
* AMP Analytics: Make the aip parameter changeable to false #7983 * Added tests * Ability to disable trigger * rolled back indentation changes * Renamed some tests * lint fixes * lint errors * lint fixes * fixed type declarations * fixed comments * updated jsdoc * updated jsdoc * lint * Falsey values * jsdoc updated * code review changes * code review changes * rolled back indentation * rolled back indentation
* Sticky ad: wait for fixed layer to complete before loading an ad * lints
* Fix scheduling with owner blocked on build * review fixes
* fetch ww.js via rtv url * unit test * fix lint
* Investigate viewport signal failures for elements in dead FIE * also, elements in dead iframes are not displayed
* Improve localhost link filtering in markdown during pr-check.js * Add TODO
* Add visual-diff test for amp-by-example * Do not check document links during push builds * Remove stray file
Now, every time, a gclid parameter is present in the page URL, an additional hit with page load timing information will be sent across.
* initial split of owners doc * initial split of owners doc * fix some links * fix some links * fix some links * add comma
* Implement replaceUrl protocol for safe URL replacements * linter * more tests
* Changed setInterval for setTimeout * Changed var names to camel case and code clean up * Added comments * Fixed condition and added comment on timer * Added comment to run test again * Clear the timeout when the ad is not in view. Moved the view call to a separate function. * Add comment to restart tests
* Enable _ga cookie for googleanalytics, doubleclick and adsense. * fix test
* Add unit test for ad concurrent load. * Add unit test for ad concurrent load.
All elements get not only `show` but also `hide` and `toggleVisibility`, as documented in an earlier section of this file.
* Added README for amp-ima-video. Fixed IMA SDK link. Really fixed IMA SDK link. Fixed again. Added space Fixed overvie wheader. Removed slash file. * Fixed closing tag. * Updated to resolve comments. * Updated to address missed comments * Updated to resolve comments. * Fix comma -> period.
…cify initial values (#9584)
…9612) * Include experiment id on all Doubleclick Fast Fetch Requests * fix test coverage
* Change image to static link hosted on ampproject.org * Update amp-cors-requests.md Remove exclamation since it doesn't render correctly in ampproject.org.
* Test on Travis using Node v4 * Use strict * Fix loop
* Revision bump. * Allow style attributes on `<stop>` elements, an oversight.
* Animations: extract keyframes from styles * review fixes * review fixes * moved decl to externs
* move messaging to npm * version * source * fix * fix * fix * lint * lint, check-types fixes * fix
…ires (#9553) * Add autocomplete examples and amp-bind and action changes it requires * Prevent null value binding in query string * Improve formatting * Replace autocomplete with autosuggest * Rename to autosuggest.amp.html and add to validation test * Remove specific case now that bind handles initial value attrs
* Animation compositions * review fixes * protect against recursive vars + tests * lints
* squash bind-in-fie commits * fix actions test * kevin's comments * a couple more comments
torch2424
pushed a commit
that referenced
this pull request
Mar 1, 2019
* creating new amp-smartlinks extension * BAM-2584 AMP-Smartlinks (#3) * adding example page and amp-smartlinks to bundles.config * creating amp-smartlinks scaffolding * BAM-2584 adding hardcoded POC implementation of amp-smartlinks * adding new constants file and linkmate file/class * adding linkmate call and association working with link-rewrite service * add amp config call and update workflow to use those values * setup initial amp-smartlinks and linkmate workflow * adding new config variables for link attribute and selector * add tests for amp-smartlinks * add test for linkmate.js * add more thorough anchorList check in runSmartlinks * adding code comments, new constants structure and better options validation * update amp-smartlinks to have helpful information * updating global vars and cleaning up main files * clean up tests and add more explicit type assertions * clean up jsdoc tags * BAM-2585 Whitelist import, fix type errors, and replace user.assert with userAssert (#4) * BAM-2585 whitelist navigation import and fix type errors * replace user.assert with userAssert * BAM-2585 fix validator and type check (#5) * more validator fixes (#6) * BAM-2585 Fix validator, copyright, and whitespace (#7) * alphabetize validator, fix whitespace, and add valid tag * update year in copyright statement * BAM-2585 move `link-rewriter` to import statements and updating types (#8) * BAM-2585 remove link-rewriter and switch to importing from skimlinks extension * clean up promise chain and more descriptive API comments * update xhr to pull from ampdoc.win and add types to constants.js * fix type in buildPageImpressionPayload_ * update validator with new empty value check (#9) * update validator for exclusive-links * switch page-impression API request to customEventReporter (ampproject#11) * BAM-2585 fix jsdoc in linkmate-options and unnecessary param in page_impression request (ampproject#12) * fix jsdoc for linkmate params and make runLinkmate more readable (ampproject#13) * add try/catch on amp_config fetch and updated constants.js * remove bad type in constants.js and add check for existing shop-links (ampproject#14) * add check for auction_id in mapLinks and add jsdoc for SMARTLINKS_REWRITER_ID * fix type notation in constants.js and linkmate-options.js * fix indentation in example file * add note to README describing link-rewriter priority queue behavior (ampproject#15) * add exception to compile.js for amp-skimlinks * update validator to use empty value as indicator linkmate param * fix validator and linkmate-options to use new config style (ampproject#16) * updating tests for linkmate-options.js * remove redundant userAssert in linkmate-options * update tests to reflect config changes * update tests to send accurate config params * update readme to refelct config changes and more accurate function names in linkmate-options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please pick a meaningful title for your pull request using sentence case.
Do not overuse punctuation in the title like
(chore):. If it is helpful feel free to start with a project name, though, likeProjectX: Implement some feature.Title instructions above.
Enter a succinct description of what is achieved by the PR. Ideally describe why the change is being made.
Bullet points like
really help with making this more readable.
Fixes/Implements/Related-to #1 (enter issue number, except in rare cases where none exists).