amp-youtube: Autoplay animation to pause when video ends#9602
amp-youtube: Autoplay animation to pause when video ends#9602aghassemi merged 1 commit intoampproject:masterfrom
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
fe99823 to
b2a5614
Compare
|
CLAs look good, thanks! |
There was a problem hiding this comment.
Awesome!
For the PR title, let's do:
"amp-youtube: autoplay animation to pause when video ends"
PR titles end up being the commit message which show up in Release Notes. Best titles would be something that will be useful to an AMP user reading the release notes.
examples/amp-youtube.amp.html
Outdated
| <amp-youtube | ||
| id="myVideo" | ||
| data-videoid="lBTCB7yLs8Y" | ||
| data-videoid="a2bESrN3Hig" |
There was a problem hiding this comment.
Let's change back to lBTCB7yLs8Y
a2bESrN3Hig almost gave me a headache :)
| * @private | ||
| */ | ||
|
|
||
| /* Correct PlayerStates taken from: https://developers.google.com/youtube/iframe_api_reference#Playback_status */ |
There was a problem hiding this comment.
// for non-method signature comments
b2a5614 to
ba5db0d
Compare
ba5db0d to
43889d6
Compare
|
Made the changes! |
aghassemi
left a comment
There was a problem hiding this comment.
LGTM. will merge when CI passes.
This fixes the bug where Youtube videos do not send a pause event when ended ( https://github.com/ampproject/amphtml/issues/5776 ).
Changes
Closes #5776