Skip to content

Do not check document links during push builds#9213

Merged
dreamofabear merged 3 commits intoampproject:masterfrom
rsimha:2017-05-08-FixMaster
May 8, 2017
Merged

Do not check document links during push builds#9213
dreamofabear merged 3 commits intoampproject:masterfrom
rsimha:2017-05-08-FixMaster

Conversation

@rsimha
Copy link
Copy Markdown
Contributor

@rsimha rsimha commented May 8, 2017

Skip checking document links during push builds, since there is no available commit range or list of files on which to work. This is fine since the document link check is already run as a presubmit for PRs.

@rsimha rsimha requested a review from dreamofabear May 8, 2017 21:43
@rsimha rsimha added this to the Sprint H1 May milestone May 8, 2017
@@ -0,0 +1,1287 @@
<!doctype html>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crap, that snuck in from a different branch.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@rsimha
Copy link
Copy Markdown
Contributor Author

rsimha commented May 8, 2017

@choumx, could you merge this, please?

@dreamofabear dreamofabear merged commit 20555cb into ampproject:master May 8, 2017
@rsimha rsimha deleted the 2017-05-08-FixMaster branch May 8, 2017 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants