Print a clearer error message when flag-config and non-flag-config files are in the same PR#9166
Merged
aghassemi merged 6 commits intoampproject:masterfrom May 5, 2017
rsimha:2017-05-05-FlagConfigMessage
Merged
Print a clearer error message when flag-config and non-flag-config files are in the same PR#9166aghassemi merged 6 commits intoampproject:masterfrom rsimha:2017-05-05-FlagConfigMessage
aghassemi merged 6 commits intoampproject:masterfrom
rsimha:2017-05-05-FlagConfigMessage
Conversation
Merged
Contributor
Author
|
@lannka / @aghassemi, this should make the failure message less cryptic. Could one of you please merge this after review? (I don't have merge permissions yet.) |
jridgewell
reviewed
May 5, 2017
build-system/pr-check.js
Outdated
| console.log('Please make your changes in separate pull requests.'); | ||
| console.log(util.colors.yellow( | ||
| 'NOTE: If you see a long list of unrelated files below, it is ' + | ||
| 'likely because your branch is very old.')); |
Contributor
There was a problem hiding this comment.
"likely because you need to resync your branch"
Contributor
Author
There was a problem hiding this comment.
Mentioned in the next sentence. I've reworded it anyway. Done.
aghassemi
approved these changes
May 5, 2017
Contributor
aghassemi
left a comment
There was a problem hiding this comment.
Please make a reminder to remove the second part of the message after a few months.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From time to time, people hit this error because of a really old branch and wonder what this error is all about. Make the error text easier to spot and easier to understand.