amp-bind: manually add custom functions to bind whitelist#9223
Merged
kmh287 merged 2 commits intoampproject:masterfrom May 9, 2017
Merged
amp-bind: manually add custom functions to bind whitelist#9223kmh287 merged 2 commits intoampproject:masterfrom
kmh287 merged 2 commits intoampproject:masterfrom
Conversation
dreamofabear
approved these changes
May 9, 2017
| }); | ||
|
|
||
| // Custom functions (non-js-built-ins) must be added manually as their names | ||
| // will be minifid at compile time. |
Contributor
|
I still think we should stop using |
|
This bug was related to Closure rather than browser support of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copyAndSplicehas its name minified at compile time. I tried the@exportannotation, putting the function at the module level and exporting it, but this is the only way I could get around the problem. I'm open to more suggestions if you have any.Fixes #9222
/to @choumx