Change link checker to warning-only#9219
Merged
aghassemi merged 3 commits intoampproject:masterfrom May 9, 2017
rsimha:2017-05-08-NonBlockingLinkChecker
Merged
Change link checker to warning-only#9219aghassemi merged 3 commits intoampproject:masterfrom rsimha:2017-05-08-NonBlockingLinkChecker
aghassemi merged 3 commits intoampproject:masterfrom
rsimha:2017-05-08-NonBlockingLinkChecker
Conversation
dreamofabear
reviewed
May 9, 2017
build-system/tasks/check-links.js
Outdated
| util.log( | ||
| util.colors.red('ERROR'), 'Dead links found in', | ||
| util.colors.magenta(markdownFiles[index]), '(please update it).'); | ||
| util.colors.yellow('WARNING'), 'Dead links potentially found in', |
There was a problem hiding this comment.
Nit: "Possible dead link found in"
| util.colors.yellow('WARNING'), | ||
| 'Dead links potentially found. Please update', | ||
| util.colors.magenta(filesWithDeadLinks.join(',')), | ||
| 'if necessary.'); |
There was a problem hiding this comment.
Why have this warning message display twice? Looks like once for each file and once overall?
Contributor
Author
There was a problem hiding this comment.
Correct, this is for the case where many md files are edited in one PR, so all dead links can be detected in one go. Saves the trouble of having to re-test after every fix.
dreamofabear
approved these changes
May 9, 2017
build-system/tasks/check-links.js
Outdated
| util.log( | ||
| util.colors.red('ERROR'), 'Dead links found in', | ||
| util.colors.magenta(markdownFiles[index]), '(please update it).'); | ||
| util.colors.yellow('WARNING'), 'Possible dead link(s) found in', |
There was a problem hiding this comment.
Sorry one more nit: each argument on its own line for consistency.
Contributor
Author
|
@choumx, seems like I still don't have write access. Could you merge this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the link checker a warning-only tool that does not block PR merges. This is because some md files contain script tags that have links in them, and they are being detected as false negatives. If we figure out a way to ignore such links, we can consider making it PR blocking once again.
/to @dvoytenko @choumx