Split information about OWNERS out of GOVERNANCE.md#9205
Merged
mrjoro merged 6 commits intoampproject:masterfrom May 8, 2017
Merged
Split information about OWNERS out of GOVERNANCE.md#9205mrjoro merged 6 commits intoampproject:masterfrom
mrjoro merged 6 commits intoampproject:masterfrom
Conversation
aghassemi
approved these changes
May 8, 2017
GOVERNANCE.md
Outdated
| * In the unlikely event that there are no more Core Committers, Google Inc. will appoint a new Tech Lead. | ||
| * Significant feature development and changes to AMP require following the ["Intent to implement"](./CONTRIBUTING.md#feature-development) process including approval from the Tech Lead and one Core Committer. | ||
| * Significant feature development and changes to AMP require following the ["Intent to implement"](./CONTRIBUTING.md#contributing-features) process including approval from the Tech Lead and one Core Committer. | ||
| * Before contributions can be merged into the AMP Project approval must be given by an [Owner and a Core Committer](./contributing/owners-and-committers.md) |
Contributor
There was a problem hiding this comment.
needs comma? ...AMP Project, approval must be given...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a fix for issue #8183.
This separates documentation on the approvals a PR requires + the concept of OWNERS out of GOVERNANCE which now focuses more on what the Core Committers are/etc.
cc @cramforce @erwinmombay