Skip to content

Add tests to amp-app-banner covering various browsers and platforms#9631

Merged
muxin merged 1 commit intoampproject:masterfrom
muxin:improve-banner-tests
May 31, 2017
Merged

Add tests to amp-app-banner covering various browsers and platforms#9631
muxin merged 1 commit intoampproject:masterfrom
muxin:improve-banner-tests

Conversation

@muxin
Copy link
Copy Markdown
Contributor

@muxin muxin commented May 31, 2017

No description provided.

@muxin muxin requested a review from aghassemi May 31, 2017 06:36
@muxin muxin force-pushed the improve-banner-tests branch from db8184d to ffcddcd Compare May 31, 2017 06:50
Copy link
Copy Markdown
Contributor

@aghassemi aghassemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@muxin muxin merged commit c12d5fa into ampproject:master May 31, 2017
@muxin muxin deleted the improve-banner-tests branch May 31, 2017 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants