Test on Travis using Node v4#9575
Merged
jridgewell merged 3 commits intoampproject:masterfrom May 30, 2017
Merged
Conversation
erwinmombay
approved these changes
May 26, 2017
ff3dc99 to
2ea4237
Compare
erwinmombay
pushed a commit
that referenced
this pull request
May 31, 2017
* Test on Travis using Node v4 * Use strict * Fix loop
Member
|
looks like this is breaking validator runs since the validator uses |
Contributor
|
related? |
Member
|
@aghassemi no, that is a node 8 breaking change |
Contributor
Author
|
@ampproject/validator is aware. |
petekip
pushed a commit
to petekip/amphtml
that referenced
this pull request
Jul 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.