Skip to content

Make sure BindEvaluator always exists#9229

Merged
dreamofabear merged 1 commit intoampproject:masterfrom
dreamofabear:bind-evaluator-init
May 9, 2017
Merged

Make sure BindEvaluator always exists#9229
dreamofabear merged 1 commit intoampproject:masterfrom
dreamofabear:bind-evaluator-init

Conversation

@dreamofabear
Copy link
Copy Markdown

Fixes #9228.

  • bind.addBindings isn't called on pages with 0 bindings.

/to @kmh287

@dreamofabear dreamofabear requested a review from kmh287 May 9, 2017 19:20
@kmh287
Copy link
Copy Markdown
Contributor

kmh287 commented May 9, 2017

Aren't all these changes in #8956?

@dreamofabear
Copy link
Copy Markdown
Author

Yea, I'm going to hold off on merging that for few more days. Want to verify that #9154 is fixed first.

Copy link
Copy Markdown
Contributor

@kmh287 kmh287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, LGTM

@dreamofabear dreamofabear merged commit 1e6432d into ampproject:master May 9, 2017
@dreamofabear dreamofabear deleted the bind-evaluator-init branch May 9, 2017 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants