Skip to content

Allow more than one sidebar on the page#9165

Merged
aghassemi merged 2 commits intoampproject:masterfrom
aghassemi:sidebar
May 5, 2017
Merged

Allow more than one sidebar on the page#9165
aghassemi merged 2 commits intoampproject:masterfrom
aghassemi:sidebar

Conversation

@aghassemi
Copy link
Copy Markdown
Contributor

Closes #6104

@honeybadgerdontcare
Copy link
Copy Markdown
Contributor

Please update the corresponding html file's comment about more than one sidebar: https://github.com/ampproject/amphtml/blob/master/extensions/amp-sidebar/0.1/test/validator-amp-sidebar.html#L49

I remember seeing a discussion about allowing only one left sidebar and one right sidebar, but not two left sidebars or two right sidebars. Is that no longer the case?

@camelburrito
Copy link
Copy Markdown
Contributor

The reason we did not allow this was we did not want to open 2 sidebars and give no means of closing them (unless the author adds a close button on the sidebar).

We would also need this feature?
#3320

@aghassemi
Copy link
Copy Markdown
Contributor Author

@camelburrito see comments on #6104 as I have mentioned I like to do this part without waiting for #3320

@aghassemi
Copy link
Copy Markdown
Contributor Author

@honeybadgerdontcare maybe although considering with amp-bind now devs can have complicated logic, I can see use-case of having multiple sidebars on the same-side and using bind to open the one that makes sense given the state of the app.

Copy link
Copy Markdown
Contributor

@honeybadgerdontcare honeybadgerdontcare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a validation perspective this change looks good. I'll let @camelburrito work with @aghassemi on the details around #3320 and #6104.

@honeybadgerdontcare
Copy link
Copy Markdown
Contributor

@aghassemi yeah that makes sense, thanks for clarifying. It would be useful to have this if it was exercised in the right fashion.

@camelburrito
Copy link
Copy Markdown
Contributor

@aghassemi i am okay with this as long as you promise #3320 will make it in soon :)

@aghassemi
Copy link
Copy Markdown
Contributor Author

@camelburrito I am not yet fully convinced we need #3320, let's discuss on that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants