Allow more than one sidebar on the page#9165
Conversation
|
Please update the corresponding html file's comment about more than one sidebar: https://github.com/ampproject/amphtml/blob/master/extensions/amp-sidebar/0.1/test/validator-amp-sidebar.html#L49 I remember seeing a discussion about allowing only one left sidebar and one right sidebar, but not two left sidebars or two right sidebars. Is that no longer the case? |
|
The reason we did not allow this was we did not want to open 2 sidebars and give no means of closing them (unless the author adds a close button on the sidebar). We would also need this feature? |
|
@camelburrito see comments on #6104 as I have mentioned I like to do this part without waiting for #3320 |
|
@honeybadgerdontcare maybe although considering with |
honeybadgerdontcare
left a comment
There was a problem hiding this comment.
From a validation perspective this change looks good. I'll let @camelburrito work with @aghassemi on the details around #3320 and #6104.
|
@aghassemi yeah that makes sense, thanks for clarifying. It would be useful to have this if it was exercised in the right fashion. |
|
@aghassemi i am okay with this as long as you promise #3320 will make it in soon :) |
|
@camelburrito I am not yet fully convinced we need #3320, let's discuss on that issue. |
Closes #6104