Allow variable substitution for whitelisted origins#7344
Conversation
Fixes ampproject#6141 Allow for an additional domain (or list of domains) for which variable substitution is allowed in links.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
| return true; | ||
| } | ||
|
|
||
| const meta = this.ampdoc.getRootNode().querySelector( |
There was a problem hiding this comment.
Thanks, is whitelisted now.
cramforce
left a comment
There was a problem hiding this comment.
Thanks! Looks perfect! One comment on the test. Otherwise this can go right in.
| querySelector: selector => { | ||
| if (selector.startsWith('meta')) { | ||
| return { | ||
| getAttribute: () => {return 'https://whitelisted.com';}, |
There was a problem hiding this comment.
Please add a space separated second origin.
|
I signed it! |
|
CLAs look good, thanks! |
|
@cramforce i've updated the test. are we waiting on anything else? |
|
@rudygalfi We are good with this, right? |
|
LGTM |
Fixes ampproject#6141 Allow for an additional domain (or list of domains) for which variable substitution is allowed in links.
Fixes ampproject#6141 Allow for an additional domain (or list of domains) for which variable substitution is allowed in links.
Allow for an additional domain (or list of domains) for which variable substitution is allowed in links.
amp-link-variable-allowed-origindata-amp-replace)Implements #6141