Page-level visibility time for embed performance reporting#7241
Page-level visibility time for embed performance reporting#7241dvoytenko merged 2 commits intoampproject:masterfrom
Conversation
|
LGTM. We probably want to add the |
tdrl
left a comment
There was a problem hiding this comment.
Generally LGTM, modulo comment re: inserting into googleLifecycleReporterFactory.
One small suggestion: Would it make more sense to call it mostRecentVisibleTime instead of lastVisibleTime? When I first read it, I took lastVisible to mean something like "last time before the page is destroyed", rather than "most recent time that page became visible".
This seems like a good suggestion and I was going to do it. But I found bunch of similarly named properties with that exact meaning named "last visible time". So, with that, I'd rather keep it as is. But thanks a lot for suggestion. |
|
@tdrl Two changes since last review:
PTAL. |
…t#7241) * Page-level visibility time for embed performance reporting * ping URL parameters and layout ping
…t#7241) * Page-level visibility time for embed performance reporting * ping URL parameters and layout ping
Classical performance reporting against the
navigationStarttime has issues in AMP since AMP pauses all processing while document is invisible. I propose here to also report first/last visibility times.@tdrl Please guide me what other steps are needed to proceed with these three new metrics?