Skip to content

add advance bidder support for openx amp ad#7221

Merged
erwinmombay merged 3 commits intoampproject:masterfrom
openx:openx-amp-ad-advance
Jan 30, 2017
Merged

add advance bidder support for openx amp ad#7221
erwinmombay merged 3 commits intoampproject:masterfrom
openx:openx-amp-ad-advance

Conversation

@rjvelicaria
Copy link
Copy Markdown
Contributor

#7159

  • use advance bidder implementation when both auid and dfpslot are defined

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@lannka lannka self-requested a review January 27, 2017 00:20
@lannka lannka self-assigned this Jan 27, 2017
@rjvelicaria
Copy link
Copy Markdown
Contributor Author

Company Name: OpenX Technologies, Inc.

@lannka
Copy link
Copy Markdown
Contributor

lannka commented Jan 27, 2017

@rjvelicaria can you fix the type checks? you will want to add the new name to ads.extern.js

To pass the CLA robot check, can you try mention "CLA" together with your exact company name?

@rjvelicaria
Copy link
Copy Markdown
Contributor Author

rjvelicaria commented Jan 27, 2017

Okay, I'll take a look at ads.extern.js

@CLA OpenX Technologies, Inc.

@rjvelicaria
Copy link
Copy Markdown
Contributor Author

@CLA OpenX Technologies, Inc.

Trying to trigger it again since it didn't report back.

@lannka
Copy link
Copy Markdown
Contributor

lannka commented Jan 30, 2017

@erwinmombay seems we're getting trouble with CLA, could you force merge the PR?

@erwinmombay erwinmombay merged commit f0b87e6 into ampproject:master Jan 30, 2017
torch2424 pushed a commit to torch2424/amphtml that referenced this pull request Feb 14, 2017
* add advance bidder support for openx amp ad

* update ads.extern.js for openx amp ad

* add data.dfpSlot to ads.extern.js
mrjoro pushed a commit to mrjoro/amphtml that referenced this pull request Apr 28, 2017
* add advance bidder support for openx amp ad

* update ads.extern.js for openx amp ad

* add data.dfpSlot to ads.extern.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants