add advance bidder support for openx amp ad#7221
add advance bidder support for openx amp ad#7221erwinmombay merged 3 commits intoampproject:masterfrom openx:openx-amp-ad-advance
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
Company Name: OpenX Technologies, Inc. |
|
@rjvelicaria can you fix the type checks? you will want to add the new name to ads.extern.js To pass the CLA robot check, can you try mention "CLA" together with your exact company name? |
|
Okay, I'll take a look at ads.extern.js @CLA OpenX Technologies, Inc. |
|
@CLA OpenX Technologies, Inc. Trying to trigger it again since it didn't report back. |
|
@erwinmombay seems we're getting trouble with CLA, could you force merge the PR? |
* add advance bidder support for openx amp ad * update ads.extern.js for openx amp ad * add data.dfpSlot to ads.extern.js
* add advance bidder support for openx amp ad * update ads.extern.js for openx amp ad * add data.dfpSlot to ads.extern.js
#7159