Send expected errors to expected bucket#7650
Merged
jridgewell merged 2 commits intoampproject:masterfrom Feb 21, 2017
Merged
Conversation
Contributor
Author
@erwinmombay, how do I do that? Actually, you'll probably need to do that since I don't have admin permissions. |
Member
|
@jridgewell will do. |
Contributor
Author
|
Merge afterwards, please. |
cramforce
reviewed
Feb 21, 2017
| errorType += "-canary" | ||
| isCanary = true; | ||
| } | ||
| if r.URL.Query().Get("ex") == "1" { |
Member
There was a problem hiding this comment.
Please increment version number in app.yaml
Member
|
ive updated the filters on the metrics |
erwinmombay
approved these changes
Feb 21, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
* Send expected errors to expected bucket * Increment errortracker version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want them out of my error logs.