Replace CLICK_X and CLICK_Y in anchor href for amp-inabox.#7660
Merged
lannka merged 3 commits intoampproject:masterfrom Feb 21, 2017
Merged
Replace CLICK_X and CLICK_Y in anchor href for amp-inabox.#7660lannka merged 3 commits intoampproject:masterfrom
lannka merged 3 commits intoampproject:masterfrom
Conversation
keithwrightbos
approved these changes
Feb 21, 2017
| */ | ||
| function maybeExpandUrlParams(ampdoc, e) { | ||
| const target = closestByTag(dev().assertElement(e.target), 'A'); | ||
| if (!target || !target.href) { |
Contributor
There was a problem hiding this comment.
Given you check getAttribute('href') below, seems target.href here is unnecessary
Contributor
Author
There was a problem hiding this comment.
logically it's a bit different. it could be the case that it does not have href but have ORIG_HREF_ATTRIBUTE
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
…t#7660) * Replace CLICK_X and CLICK_Y in anchor href for amp-inabox. * Fix lint errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6385