Update amp-cache-guidelines.md with adding a new cache to the AMP ecosystem#7578
Merged
cramforce merged 3 commits intoampproject:masterfrom Feb 22, 2017
Merged
Update amp-cache-guidelines.md with adding a new cache to the AMP ecosystem#7578cramforce merged 3 commits intoampproject:masterfrom
cramforce merged 3 commits intoampproject:masterfrom
Conversation
Contributor
|
/to @lannka, @cramforce |
cramforce
requested changes
Feb 16, 2017
spec/amp-cache-guidelines.md
Outdated
|
|
||
| * Contact relevant publishers to make sure they update their CORS policies to include your origin. | ||
| * Publicly announce your cache so people know where to find your documentation. | ||
| * Examples of third-party AMP Cache providers: |
Member
There was a problem hiding this comment.
Google is also a third party.
Member
There was a problem hiding this comment.
Lets add Google and remove the third party since there is no first party.
|
|
||
| ## Guidelines: Adding a new cache to the AMP ecosystem | ||
|
|
||
| * Contact relevant publishers to make sure they update their CORS policies to include your origin. |
Member
There was a problem hiding this comment.
I know that this is the only way right now, but it obviously doesn't scale, which means UX will be bad :(
Contributor
Author
|
Done (like this):
|
lannka
approved these changes
Feb 16, 2017
|
|
||
| ## Guidelines: Adding a new cache to the AMP ecosystem | ||
|
|
||
| * Contact relevant publishers to make sure they update their CORS policies to include your origin. |
Contributor
There was a problem hiding this comment.
can you also add a link to our CORS guidelines?
Contributor
Author
There was a problem hiding this comment.
@lannka Done as per:
- Contact relevant publishers to make sure they update their CORS policies to include your origin.
- For further information please refer to the CORS Security in AMP Guidelines.
Contributor
Author
|
@lannka @cramforce Are we good on the latest changes? |
cramforce
approved these changes
Feb 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6515