Change the spec for amp-audio[autoplay]#7574
Merged
Gregable merged 2 commits intoampproject:masterfrom Feb 15, 2017
Gregable:autoplay
Merged
Change the spec for amp-audio[autoplay]#7574Gregable merged 2 commits intoampproject:masterfrom Gregable:autoplay
Gregable merged 2 commits intoampproject:masterfrom
Gregable:autoplay
Conversation
this is a boolean attribute, rather than the enum mentioned today.
honeybadgerdontcare
approved these changes
Feb 15, 2017
ghost
reviewed
Feb 15, 2017
| The `autoplay` attribute allows the author to specify when - if ever - the animated image will autoplay. | ||
|
|
||
| The presence of the attribute alone implies that the animated image will always autoplay. The author may specify values to limit when the animations will autoplay. Allowable values are `desktop`, `tablet`, or `mobile`, with multiple values separated by a space. The runtime makes a best-guess approximation to the device type to apply this value. | ||
| If present, the attribute implies that the audio start playing as soon as it is |
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
* Change the spec for `amp-audio[autoplay]` to correctly indicate that this is a boolean attribute, rather than the enum mentioned today. * Change amp-audio language to reference 'audio' rather than 'image'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the spec for
amp-audio[autoplay]to correctly indicate that this is a boolean attribute, rather than the enum mentioned today.