An additional required file was added for Rambler&Co ad network#7541
Merged
zhouyx merged 2 commits intoampproject:masterfrom Feb 16, 2017
Merged
An additional required file was added for Rambler&Co ad network#7541zhouyx merged 2 commits intoampproject:masterfrom
zhouyx merged 2 commits intoampproject:masterfrom
Conversation
Contributor
Contributor
|
One question. What's the cost of |
Contributor
Author
|
I can load the required scripts asynchronously using loadScript method. I think it will be better. |
Contributor
|
LGTM |
zhouyx
approved these changes
Feb 16, 2017
Contributor
|
@CrazySquirrel Thanks for the Pull Request. Merged. |
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
…roject#7541) * Additional required file was added * Asynchronous scripts loading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An additional required js file was added to amp-ad tag type capirs. It is necessary for some ad types in Rambler&Co ad network.