add url + sourceUrl to the channel_open message (amp-viewer-integration)#7466
Merged
chenshay merged 7 commits intoampproject:masterfrom Feb 16, 2017
Merged
add url + sourceUrl to the channel_open message (amp-viewer-integration)#7466chenshay merged 7 commits intoampproject:masterfrom
chenshay merged 7 commits intoampproject:masterfrom
Conversation
dvoytenko
suggested changes
Feb 11, 2017
| dev().fine(TAG, 'Channel has been opened!'); | ||
| this.setup_(messaging, viewer); | ||
| }); | ||
| const messaging = new Messaging(this.win, pipe); |
Contributor
There was a problem hiding this comment.
Let's rename pipe to port. I think it will haunt me forever now :)
| const messaging = new Messaging(this.win, pipe); | ||
| const ampDoc = getAmpDoc(this.win.document); | ||
| return messaging.sendRequest(RequestNames.CHANNEL_OPEN, { | ||
| url: ampDoc.getUrl(), |
Contributor
|
@chenshay: Can you update the PR title to something more descriptive? |
dvoytenko
suggested changes
Feb 14, 2017
| ampViewerIntegration.openChannelAndStart_(viewer, ampDocSrc, messaging); | ||
| expect(sendRequestSpy).to.have.been.calledWith('channelOpen', { | ||
| sourceUrl: 'http://localhost:9876/test/fixtures/served/ampdoc-with-messaging.html', | ||
| url: '/test/fixtures/served/ampdoc-with-messaging.html', |
Contributor
There was a problem hiding this comment.
Hmm. This is not an absolute URL? They should all be absolute...
Contributor
Author
There was a problem hiding this comment.
this is what's returned from getSourceUrl(ampdocUrl)
dvoytenko
approved these changes
Feb 16, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
…on) (ampproject#7466) * url + sourceUrl * rename * added test * remove only * fix * test fix * test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #7300