Relaxing some form requirements and errors#7530
Merged
mkhatib merged 3 commits intoampproject:masterfrom Feb 14, 2017
Merged
Conversation
jridgewell
reviewed
Feb 14, 2017
src/document-submit.js
Outdated
| 'form target=%s is invalid can only be _blank or _top: %s', target, form); | ||
| if (actionXhr) { | ||
| checkCorsUrl(actionXhr); | ||
| if (!target) { |
Contributor
There was a problem hiding this comment.
Please flip the if statement.
muxin
reviewed
Feb 14, 2017
src/document-submit.js
Outdated
| 'form target=%s is invalid can only be _blank or _top: %s', target, form); | ||
| if (actionXhr) { | ||
| checkCorsUrl(actionXhr); | ||
| if (!target) { |
Contributor
There was a problem hiding this comment.
Add a test for no target case?
Contributor
Author
|
PTAL 👀 |
muxin
approved these changes
Feb 14, 2017
jridgewell
approved these changes
Feb 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #5607
Related #5670
Closes #5877